Read Executable from factory instead of from stdlib

mislav · mislav · commit cfbfb578f07e · 2021-03-04T13:41:50.000+01:00
diff --git a/cmd/gh/main.go b/cmd/gh/main.go
@@ -163,10 +163,7 @@ func main() {
 
 	newRelease := <-updateMessageChan
 	if newRelease != nil {
-		isHomebrew := false
-		if ghExe, err := os.Executable(); err == nil {
-			isHomebrew = isUnderHomebrew(ghExe)
-		}
+		isHomebrew := isUnderHomebrew(cmdFactory.Executable)
 		if isHomebrew && isRecentRelease(newRelease.PublishedAt) {
 			// do not notify Homebrew users before the version bump had a chance to get merged into homebrew-core
 			return
