update go-liveshare@v0.11.0

adonovan · adonovan · commit cee761238ba1 · 2021-09-02T15:54:00.000-04:00
diff --git a/cmd/ghcs/logs.go b/cmd/ghcs/logs.go
@@ -70,8 +70,6 @@ func logs(ctx context.Context, tail bool, codespaceName string) error {
 		return fmt.Errorf("error getting ssh server details: %v", err)
 	}
 
-	tunnel := liveshare.NewPortForwarder(session, "sshd", localSSHPort, remoteSSHServerPort)
-
 	cmdType := "cat"
 	if tail {
 		cmdType = "tail -f"
@@ -86,7 +84,8 @@ func logs(ctx context.Context, tail bool, codespaceName string) error {
 
 	tunnelClosed := make(chan error, 1)
 	go func() {
-		tunnelClosed <- tunnel.Forward(ctx) // error is non-nil
+		fwd := liveshare.NewPortForwarder(session, "sshd", remoteSSHServerPort)
+		tunnelClosed <- fwd.ForwardToLocalPort(ctx, localSSHPort) // error is non-nil
 	}()
 
 	cmdDone := make(chan error, 1)
diff --git a/cmd/ghcs/ports.go b/cmd/ghcs/ports.go
@@ -278,9 +278,9 @@ func forwardPorts(log *output.Logger, codespaceName string, ports []string) erro
 	for _, pair := range portPairs {
 		log.Printf("Forwarding ports: remote %d <=> local %d\n", pair.remote, pair.local)
 		name := fmt.Sprintf("share-%d", pair.remote)
-		fwd := liveshare.NewPortForwarder(session, name, pair.remote, pair.local)
 		go func() {
-			errc <- fwd.Forward(ctx) // error always non-nil
+			fwd := liveshare.NewPortForwarder(session, name, pair.remote)
+			errc <- fwd.ForwardToLocalPort(ctx, pair.local) // error always non-nil
 		}()
 	}
 
diff --git a/cmd/ghcs/ssh.go b/cmd/ghcs/ssh.go
@@ -90,16 +90,15 @@ func ssh(ctx context.Context, sshProfile, codespaceName string, localSSHServerPo
 		}
 	}
 
-	tunnel := liveshare.NewPortForwarder(session, "sshd", localSSHServerPort, remoteSSHServerPort)
-
 	connectDestination := sshProfile
 	if connectDestination == "" {
 		connectDestination = fmt.Sprintf("%s@localhost", sshUser)
 	}
 
 	tunnelClosed := make(chan error)
 	go func() {
-		tunnelClosed <- tunnel.Forward(ctx) // error is always non-nil
+		fwd := liveshare.NewPortForwarder(session, "sshd", remoteSSHServerPort)
+		tunnelClosed <- fwd.ForwardToLocalPort(ctx, localSSHServerPort) // error is always non-nil
 	}()
 
 	shellClosed := make(chan error)

Original file line number	Diff line number	Diff line change
`@@ -90,16 +90,15 @@ func ssh(ctx context.Context, sshProfile, codespaceName string, localSSHServerPo`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`
`93`		`- tunnel := liveshare.NewPortForwarder(session, "sshd", localSSHServerPort, remoteSSHServerPort)`
`94`		`-`
`95`	`93`	`connectDestination := sshProfile`
`96`	`94`	`if connectDestination == "" {`
`97`	`95`	`connectDestination = fmt.Sprintf("%s@localhost", sshUser)`
`98`	`96`	`}`
`99`	`97`
`100`	`98`	`tunnelClosed := make(chan error)`
`101`	`99`	`go func() {`
`102`		`- tunnelClosed <- tunnel.Forward(ctx) // error is always non-nil`
	`100`	`+ fwd := liveshare.NewPortForwarder(session, "sshd", remoteSSHServerPort)`
	`101`	`+ tunnelClosed <- fwd.ForwardToLocalPort(ctx, localSSHServerPort) // error is always non-nil`
`103`	`102`	`}()`
`104`	`103`
`105`	`104`	`shellClosed := make(chan error)`