Rename to tries and clean up loop condition

josebalius · josebalius · commit cd6176d91189 · 2022-03-21T11:42:32.000-04:00
diff --git a/pkg/liveshare/port_forwarder_test.go b/pkg/liveshare/port_forwarder_test.go
@@ -82,11 +82,9 @@ func TestPortForwarderStart(t *testing.T) {
 
 	go func() {
 		var conn net.Conn
-		retries := 0
-		for conn == nil && retries < 2 {
+		for tries := 0; conn == nil && tries < 2; tries++ {
 			conn, err = net.DialTimeout("tcp", ":8000", 2*time.Second)
 			if conn == nil {
-				retries++
 				time.Sleep(1 * time.Second)
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -82,11 +82,9 @@ func TestPortForwarderStart(t *testing.T) {`
`82`	`82`
`83`	`83`	`go func() {`
`84`	`84`	`var conn net.Conn`
`85`		`- retries := 0`
`86`		`- for conn == nil && retries < 2 {`
	`85`	`+ for tries := 0; conn == nil && tries < 2; tries++ {`
`87`	`86`	`conn, err = net.DialTimeout("tcp", ":8000", 2*time.Second)`
`88`	`87`	`if conn == nil {`
`89`		`- retries++`
`90`	`88`	`time.Sleep(1 * time.Second)`
`91`	`89`	`}`
`92`	`90`	`}`