Fix fetching draft releases from GitHub Actions

mislav · mislav · commit c667a0bc4959 · 2021-05-18T19:44:29.000+02:00
When using GITHUB_TOKEN in Actions, the permissions on a repository are
null and therefore we can't check whether the viewer has push access or
not. The solution is to unconditionally check for draft releases instead
of trying to be smart about it. Draft releases are going to be on top,
so we don't have to paginate through all releases in a repository.
diff --git a/pkg/cmd/release/shared/fetch.go b/pkg/cmd/release/shared/fetch.go
@@ -133,11 +133,7 @@ func FetchRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagName st
 	defer resp.Body.Close()
 
 	if resp.StatusCode == 404 {
-		if canPush, err := api.CanPushToRepo(httpClient, baseRepo); err == nil && canPush {
-			return FindDraftRelease(httpClient, baseRepo, tagName)
-		} else if err != nil {
-			return nil, err
-		}
+		return FindDraftRelease(httpClient, baseRepo, tagName)
 	}
 
 	if resp.StatusCode > 299 {
@@ -230,11 +226,8 @@ func FindDraftRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagNam
 				return &r, nil
 			}
 		}
-
-		if len(releases) < perPage {
-			break
-		}
-		page++
+		//nolint:staticcheck
+		break
 	}
 
 	return nil, errors.New("release not found")

Original file line number	Diff line number	Diff line change
`@@ -133,11 +133,7 @@ func FetchRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagName st`
`133`	`133`	`defer resp.Body.Close()`
`134`	`134`
`135`	`135`	`if resp.StatusCode == 404 {`
`136`		`- if canPush, err := api.CanPushToRepo(httpClient, baseRepo); err == nil && canPush {`
`137`		`- return FindDraftRelease(httpClient, baseRepo, tagName)`
`138`		`- } else if err != nil {`
`139`		`- return nil, err`
`140`		`- }`
	`136`	`+ return FindDraftRelease(httpClient, baseRepo, tagName)`
`141`	`137`	`}`
`142`	`138`
`143`	`139`	`if resp.StatusCode > 299 {`
`@@ -230,11 +226,8 @@ func FindDraftRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagNam`
`230`	`226`	`return &r, nil`
`231`	`227`	`}`
`232`	`228`	`}`
`233`		`-`
`234`		`- if len(releases) < perPage {`
`235`		`- break`
`236`		`- }`
`237`		`- page++`
	`229`	`+ //nolint:staticcheck`
	`230`	`+ break`
`238`	`231`	`}`
`239`	`232`
`240`	`233`	`return nil, errors.New("release not found")`