WIP resuming pr create test work

nate smith · nate smith · commit c12bdc2731f2 · 2019-11-01T17:19:01.000-05:00
diff --git a/command/pr_create_test.go b/command/pr_create_test.go
@@ -0,0 +1,60 @@
+package command
+
+import (
+	//"regexp"
+	"testing"
+
+	//"github.com/github/gh-cli/context"
+	"github.com/github/gh-cli/test"
+	//"github.com/github/gh-cli/utils"
+)
+
+func TestPrCreateHelperProcess(*testing.T) {
+	if test.SkipTestHelperProcess() {
+		return
+	}
+
+	statusOutputs := map[string]string{
+		"clean": "",
+		"dirty": " M git/git.go",
+	}
+
+	args := GetTestHelperProcessArgs()
+	switch args[1] {
+	case "status":
+		fmt.Println(statusOutputs(args[0]))
+	case "push":
+		fmt.Println()
+	}
+
+	defer os.Exit(0)
+}
+
+func TestReportsUncommittedChanges(t *testing.T) {
+	repoIdFix, _ := os.Open("test/fixtures/repoId.json")
+	defer repoIdFix.Close()
+	createPrFix, _ := os.Open("test/fixtures/createPr.json")
+	defer createPrFix.Close()
+
+	http := initFakeHTTP()
+	http.StubResponse(200, repoIdFix)
+	http.StubResponse(200, createPrFix)
+
+	origGitCommand := git.GitCommand
+	defer func() {
+		git.GitCommand = origGitCommand
+	}()
+
+	git.GitCommand = test.StubExecCommand("TestPrCreateHelperProcess", "dirty")
+
+	// init blank command and just run prCreate? Or try to use RunCommand?
+
+	// output, err := test.RunCommand(RootCmd, "pr create -tfoo -bbar")
+	// if err != nil {
+	// 	t.Errorf("error running command `pr create`: %v", err)
+	// }
+
+	// if len(output) == 0 {
+	// 	panic("lol")
+	// }
+}
diff --git a/git/git.go b/git/git.go
@@ -239,6 +239,11 @@ func UncommittedChangeCount() (int, error) {
 	return count, nil
 }
 
+func Push(remote string, ref string) error {
+	cmd := GitCommand("push", "--set-upstream", remote, ref)
+	return cmd.Run()
+}
+
 var Push = func(remote string, ref string) error {
 	return Run("push", "--set-upstream", remote, ref)
 }
diff --git a/test/fixtures/createPr.json b/test/fixtures/createPr.json
@@ -0,0 +1,9 @@
+{
+  "data": {
+    "createPullRequest": {
+      "pullRequest": {
+        "url": "https://github.com/vilmibm/testing/pull/14"
+      }
+    }
+  }
+}
diff --git a/test/fixtures/repoId.json b/test/fixtures/repoId.json
@@ -0,0 +1,7 @@
+{
+  "data": {
+    "repository": {
+      "id": "a repo id"
+    }
+  }
+}
diff --git a/test/helpers.go b/test/helpers.go
@@ -16,7 +16,7 @@ type ExecStub struct {
 	ExitCode int
 }
 
-func GetExecStub(outputs map[string]ExecStub) ExecStub {
+func GetTestHelperProcessArgs() []string {
 	args := os.Args
 	for len(args) > 0 {
 		if args[0] == "--" {
@@ -25,6 +25,11 @@ func GetExecStub(outputs map[string]ExecStub) ExecStub {
 		}
 		args = args[1:]
 	}
+	return args
+}
+
+func GetExecStub(outputs map[string]ExecStub) ExecStub {
+	args := GetTestHelperProcessArgs()
 	return outputs[args[0]]
 }
 

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,11 @@ func UncommittedChangeCount() (int, error) {`
`239`	`239`	`return count, nil`
`240`	`240`	`}`
`241`	`241`
	`242`	`+func Push(remote string, ref string) error {`
	`243`	`+ cmd := GitCommand("push", "--set-upstream", remote, ref)`
	`244`	`+ return cmd.Run()`
	`245`	`+}`
	`246`	`+`
`242`	`247`	`var Push = func(remote string, ref string) error {`
`243`	`248`	`return Run("push", "--set-upstream", remote, ref)`
`244`	`249`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ type ExecStub struct {`
`16`	`16`	`ExitCode int`
`17`	`17`	`}`
`18`	`18`
`19`		`-func GetExecStub(outputs map[string]ExecStub) ExecStub {`
	`19`	`+func GetTestHelperProcessArgs() []string {`
`20`	`20`	`args := os.Args`
`21`	`21`	`for len(args) > 0 {`
`22`	`22`	`if args[0] == "--" {`
`@@ -25,6 +25,11 @@ func GetExecStub(outputs map[string]ExecStub) ExecStub {`
`25`	`25`	`}`
`26`	`26`	`args = args[1:]`
`27`	`27`	`}`
	`28`	`+ return args`
	`29`	`+}`
	`30`	`+`
	`31`	`+func GetExecStub(outputs map[string]ExecStub) ExecStub {`
	`32`	`+ args := GetTestHelperProcessArgs()`
`28`	`33`	`return outputs[args[0]]`
`29`	`34`	`}`
`30`	`35`