Allow --force and --dry-run

samcoe · samcoe · commit bf34147cc22f · 2022-03-02T21:40:56.000+02:00
diff --git a/pkg/cmd/extension/command.go b/pkg/cmd/extension/command.go
@@ -128,9 +128,6 @@ func NewCmdExtension(f *cmdutil.Factory) *cobra.Command {
 					if len(args) > 0 && flagAll {
 						return cmdutil.FlagErrorf("cannot use `--all` with extension name")
 					}
-					if flagForce && flagDryRun {
-						return cmdutil.FlagErrorf("cannot use `--force` and `--dry-run`")
-					}
 					if len(args) > 1 {
 						return cmdutil.FlagErrorf("too many arguments")
 					}
diff --git a/pkg/cmd/extension/command_test.go b/pkg/cmd/extension/command_test.go
@@ -98,12 +98,6 @@ func TestNewCmdExtension(t *testing.T) {
 			wantErr: true,
 			errMsg:  "cannot use `--all` with extension name",
 		},
-		{
-			name:    "upgrade --force and --dry-run error",
-			args:    []string{"upgrade", "test", "--force", "--dry-run"},
-			wantErr: true,
-			errMsg:  "cannot use `--force` and `--dry-run`",
-		},
 		{
 			name: "upgrade an extension",
 			args: []string{"upgrade", "hello"},

Original file line number	Diff line number	Diff line change
`@@ -128,9 +128,6 @@ func NewCmdExtension(f cmdutil.Factory) cobra.Command {`
`128`	`128`	`if len(args) > 0 && flagAll {`
`129`	`129`	return cmdutil.FlagErrorf("cannot use `--all` with extension name")
`130`	`130`	`}`
`131`		`- if flagForce && flagDryRun {`
`132`		- return cmdutil.FlagErrorf("cannot use `--force` and `--dry-run`")
`133`		`- }`
`134`	`131`	`if len(args) > 1 {`
`135`	`132`	`return cmdutil.FlagErrorf("too many arguments")`
`136`	`133`	`}`