Fix Survey's presentation of default values

mislav · mislav · commit b2de27c6241c · 2020-09-16T17:57:13.000+02:00
For default values for e.g. `Input` prompts, Survey uses the literal "white" color, which makes no sense on dark terminals and is literally invisible on light backgrounds.

This overrides Survey to output a gray color for 256-color terminals and "default" for basic terminals.
diff --git a/cmd/gh/main.go b/cmd/gh/main.go
@@ -46,6 +46,19 @@ func main() {
 	stderr := cmdFactory.IOStreams.ErrOut
 	if !cmdFactory.IOStreams.ColorEnabled() {
 		surveyCore.DisableColor = true
+	} else {
+		// override survey's poor choice of color
+		surveyCore.TemplateFuncsWithColor["color"] = func(style string) string {
+			switch style {
+			case "white":
+				if cmdFactory.IOStreams.ColorSupport256() {
+					return fmt.Sprintf("\x1b[%d;5;%dm", 38, 242)
+				}
+				return ansi.ColorCode("default")
+			default:
+				return ansi.ColorCode(style)
+			}
+		}
 	}
 
 	rootCmd := root.NewCmdRoot(cmdFactory, command.Version, command.BuildDate)
