issue/pr create: exit with nonzero status code when "Cancel" was chosen

mislav · mislav · commit b0b90afa872c · 2021-02-23T17:06:29.000+01:00
This is to indicate that the command had not finished successfully.
diff --git a/pkg/cmd/issue/create/create.go b/pkg/cmd/issue/create/create.go
@@ -249,6 +249,7 @@ func createRun(opts *CreateOptions) (err error) {
 
 		if action == prShared.CancelAction {
 			fmt.Fprintln(opts.IO.ErrOut, "Discarding.")
+			err = cmdutil.SilentError
 			return
 		}
 	} else {
diff --git a/pkg/cmd/pr/create/create.go b/pkg/cmd/pr/create/create.go
@@ -299,7 +299,8 @@ func createRun(opts *CreateOptions) (err error) {
 
 	if action == shared.CancelAction {
 		fmt.Fprintln(opts.IO.ErrOut, "Discarding.")
-		return nil
+		err = cmdutil.SilentError
+		return
 	}
 
 	err = handlePush(*opts, *ctx)

Original file line number	Diff line number	Diff line change
`@@ -249,6 +249,7 @@ func createRun(opts *CreateOptions) (err error) {`
`249`	`249`
`250`	`250`	`if action == prShared.CancelAction {`
`251`	`251`	`fmt.Fprintln(opts.IO.ErrOut, "Discarding.")`
	`252`	`+ err = cmdutil.SilentError`
`252`	`253`	`return`
`253`	`254`	`}`
`254`	`255`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,8 @@ func createRun(opts *CreateOptions) (err error) {`
`299`	`299`
`300`	`300`	`if action == shared.CancelAction {`
`301`	`301`	`fmt.Fprintln(opts.IO.ErrOut, "Discarding.")`
`302`		`- return nil`
	`302`	`+ err = cmdutil.SilentError`
	`303`	`+ return`
`303`	`304`	`}`
`304`	`305`
`305`	`306`	`err = handlePush(opts, ctx)`