Test remote parsing

mislav · mislav · commit a8aa5feb02d7 · 2019-10-17T02:25:59.000+02:00
diff --git a/context/context.go b/context/context.go
@@ -94,7 +94,11 @@ func (c *fsContext) SetBranch(b string) {
 
 func (c *fsContext) Remotes() (Remotes, error) {
 	if c.remotes == nil {
-		rem, err := parseRemotes()
+		gitRemotes, err := git.Remotes()
+		if err != nil {
+			return nil, err
+		}
+		rem, err := parseRemotes(gitRemotes)
 		if err != nil {
 			return nil, err
 		}
diff --git a/context/remote.go b/context/remote.go
@@ -42,14 +42,9 @@ type GitHubRepository struct {
 	Owner string
 }
 
-func parseRemotes() (remotes Remotes, err error) {
+func parseRemotes(gitRemotes []string) (remotes Remotes, err error) {
 	re := regexp.MustCompile(`(.+)\s+(.+)\s+\((push|fetch)\)`)
 
-	gitRemotes, err := git.Remotes()
-	if err != nil {
-		return
-	}
-
 	remotesMap := make(map[string]map[string]string)
 	for _, r := range gitRemotes {
 		if re.MatchString(r) {
diff --git a/context/remote_test.go b/context/remote_test.go
@@ -16,3 +16,41 @@ func Test_repoFromURL(t *testing.T) {
 		t.Errorf("got Name: %q", r.Name)
 	}
 }
+
+func Test_parseRemotes(t *testing.T) {
+	remoteList := []string{
+		"mona\tgit@github.com:monalisa/myfork.git (fetch)",
+		"origin\thttps://github.com/monalisa/octo-cat.git (fetch)",
+		"origin\thttps://github.com/monalisa/octo-cat-push.git (push)",
+		"upstream\thttps://example.com/nowhere.git (fetch)",
+		"upstream\thttps://github.com/hubot/tools (push)",
+	}
+	r, err := parseRemotes(remoteList)
+	if err != nil {
+		t.Error(err)
+	}
+
+	mona, err := r.FindByName("mona")
+	if err != nil {
+		t.Error(err)
+	}
+	if mona.Owner != "monalisa" || mona.Repo != "myfork" {
+		t.Errorf("got %s/%s", mona.Owner, mona.Repo)
+	}
+
+	origin, err := r.FindByName("origin")
+	if err != nil {
+		t.Error(err)
+	}
+	if origin.Owner != "monalisa" || origin.Repo != "octo-cat" {
+		t.Errorf("got %s/%s", origin.Owner, origin.Repo)
+	}
+
+	upstream, err := r.FindByName("upstream")
+	if err != nil {
+		t.Error(err)
+	}
+	if upstream.Owner != "hubot" || upstream.Repo != "tools" {
+		t.Errorf("got %s/%s", upstream.Owner, upstream.Repo)
+	}
+}
