Show progress while creating pr

KarelCoudijzer · KarelCoudijzer · commit a7b9e3916c22 · 2021-01-19T22:19:10.000+01:00
diff --git a/pkg/cmd/pr/create/create.go b/pkg/cmd/pr/create/create.go
@@ -577,7 +577,9 @@ func submitPR(opts CreateOptions, ctx CreateContext, state shared.IssueMetadataS
 		return err
 	}
 
+	opts.IO.StartProgressIndicator()
 	pr, err := api.CreatePullRequest(client, ctx.BaseRepo.(*api.Repository), params)
+	opts.IO.StopProgressIndicator()
 	if pr != nil {
 		fmt.Fprintln(opts.IO.Out, pr.URL)
 	}
@@ -613,7 +615,9 @@ func handlePush(opts CreateOptions, ctx CreateContext) error {
 	// if a head repository could not be determined so far, automatically create
 	// one by forking the base repository
 	if headRepo == nil && ctx.IsPushEnabled {
+		opts.IO.StartProgressIndicator()
 		headRepo, err = api.ForkRepo(client, ctx.BaseRepo)
+		opts.IO.StopProgressIndicator()
 		if err != nil {
 			return fmt.Errorf("error forking repo: %w", err)
 		}
@@ -677,7 +681,9 @@ func handlePush(opts CreateOptions, ctx CreateContext) error {
 			return nil
 		}
 
+		opts.IO.StartProgressIndicator()
 		err := pushBranch()
+		opts.IO.StopProgressIndicator()
 		if err != nil {
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -577,7 +577,9 @@ func submitPR(opts CreateOptions, ctx CreateContext, state shared.IssueMetadataS`
`577`	`577`	`return err`
`578`	`578`	`}`
`579`	`579`
	`580`	`+ opts.IO.StartProgressIndicator()`
`580`	`581`	`pr, err := api.CreatePullRequest(client, ctx.BaseRepo.(*api.Repository), params)`
	`582`	`+ opts.IO.StopProgressIndicator()`
`581`	`583`	`if pr != nil {`
`582`	`584`	`fmt.Fprintln(opts.IO.Out, pr.URL)`
`583`	`585`	`}`
`@@ -613,7 +615,9 @@ func handlePush(opts CreateOptions, ctx CreateContext) error {`
`613`	`615`	`// if a head repository could not be determined so far, automatically create`
`614`	`616`	`// one by forking the base repository`
`615`	`617`	`if headRepo == nil && ctx.IsPushEnabled {`
	`618`	`+ opts.IO.StartProgressIndicator()`
`616`	`619`	`headRepo, err = api.ForkRepo(client, ctx.BaseRepo)`
	`620`	`+ opts.IO.StopProgressIndicator()`
`617`	`621`	`if err != nil {`
`618`	`622`	`return fmt.Errorf("error forking repo: %w", err)`
`619`	`623`	`}`
`@@ -677,7 +681,9 @@ func handlePush(opts CreateOptions, ctx CreateContext) error {`
`677`	`681`	`return nil`
`678`	`682`	`}`
`679`	`683`
	`684`	`+ opts.IO.StartProgressIndicator()`
`680`	`685`	`err := pushBranch()`
	`686`	`+ opts.IO.StopProgressIndicator()`
`681`	`687`	`if err != nil {`
`682`	`688`	`return err`
`683`	`689`	`}`