Allow more HTTP 40x codes to trigger fallback to old OAuth flow

mislav · mislav · commit a6776d0ba2f1 · 2020-08-14T17:31:23.000+02:00
I want to avoid falling back to the old OAuth flow for just any HTTP
4xx/5xx because other statuses should be allowed to surface a problem
with a request or the server.
diff --git a/auth/oauth.go b/auth/oauth.go
@@ -57,7 +57,7 @@ func (oa *OAuthFlow) ObtainAccessToken() (accessToken string, err error) {
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode == 404 {
+	if resp.StatusCode == 401 || resp.StatusCode == 403 || resp.StatusCode == 404 {
 		// OAuth Device Flow is not available; continue with OAuth browser flow with a
 		// local server endpoint as callback target
 		return oa.localServerFlow()

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func (oa *OAuthFlow) ObtainAccessToken() (accessToken string, err error) {`
`57`	`57`	`}`
`58`	`58`	`defer resp.Body.Close()`
`59`	`59`
`60`		`- if resp.StatusCode == 404 {`
	`60`	`+ if resp.StatusCode == 401 \|\| resp.StatusCode == 403 \|\| resp.StatusCode == 404 {`
`61`	`61`	`// OAuth Device Flow is not available; continue with OAuth browser flow with a`
`62`	`62`	`// local server endpoint as callback target`
`63`	`63`	`return oa.localServerFlow()`