support fetching all workflows

vilmibm · vilmibm · commit a2dfeeb41dc0 · 2021-03-23T16:25:46.000-05:00
diff --git a/pkg/cmd/workflow/shared/shared.go b/pkg/cmd/workflow/shared/shared.go
@@ -40,16 +40,18 @@ func (w *Workflow) Base() string {
 }
 
 func GetWorkflows(client *api.Client, repo ghrepo.Interface, limit int) ([]Workflow, error) {
-	// TODO support getting all for 0 limit
 	perPage := limit
 	page := 1
-	if limit > 100 {
+	if limit > 100 || limit == 0 {
 		perPage = 100
 	}
 
 	workflows := []Workflow{}
 
-	for len(workflows) < limit {
+	for {
+		if limit > 0 && len(workflows) == limit {
+			break
+		}
 		var result WorkflowsPayload
 
 		path := fmt.Sprintf("repos/%s/actions/workflows?per_page=%d&page=%d", ghrepo.FullName(repo), perPage, page)
@@ -61,7 +63,7 @@ func GetWorkflows(client *api.Client, repo ghrepo.Interface, limit int) ([]Workf
 
 		for _, workflow := range result.Workflows {
 			workflows = append(workflows, workflow)
-			if len(workflows) == limit {
+			if limit > 0 && len(workflows) == limit {
 				break
 			}
 		}
@@ -136,8 +138,7 @@ func getWorkflowByID(client *api.Client, repo ghrepo.Interface, ID string) (*Wor
 }
 
 func getWorkflowsByName(client *api.Client, repo ghrepo.Interface, name string) ([]Workflow, error) {
-	// TODO fix limit
-	workflows, err := GetWorkflows(client, repo, 100)
+	workflows, err := GetWorkflows(client, repo, 0)
 	if err != nil {
 		return nil, fmt.Errorf("couldn't fetch workflows for %s: %w", ghrepo.FullName(repo), err)
 	}
diff --git a/pkg/cmd/workflow/view/view.go b/pkg/cmd/workflow/view/view.go
@@ -176,7 +176,7 @@ func runView(opts *ViewOptions) error {
 }
 
 func promptWorkflows(client *api.Client, repo ghrepo.Interface) (*shared.Workflow, error) {
-	workflows, err := shared.GetWorkflows(client, repo, 10)
+	workflows, err := shared.GetWorkflows(client, repo, 0)
 	if len(workflows) == 0 {
 		err = errors.New("no workflows are enabled")
 	}

Original file line number	Diff line number	Diff line change
`@@ -40,16 +40,18 @@ func (w *Workflow) Base() string {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`func GetWorkflows(client *api.Client, repo ghrepo.Interface, limit int) ([]Workflow, error) {`
`43`		`- // TODO support getting all for 0 limit`
`44`	`43`	`perPage := limit`
`45`	`44`	`page := 1`
`46`		`- if limit > 100 {`
	`45`	`+ if limit > 100 \|\| limit == 0 {`
`47`	`46`	`perPage = 100`
`48`	`47`	`}`
`49`	`48`
`50`	`49`	`workflows := []Workflow{}`
`51`	`50`
`52`		`- for len(workflows) < limit {`
	`51`	`+ for {`
	`52`	`+ if limit > 0 && len(workflows) == limit {`
	`53`	`+ break`
	`54`	`+ }`
`53`	`55`	`var result WorkflowsPayload`
`54`	`56`
`55`	`57`	`path := fmt.Sprintf("repos/%s/actions/workflows?per_page=%d&page=%d", ghrepo.FullName(repo), perPage, page)`
`@@ -61,7 +63,7 @@ func GetWorkflows(client *api.Client, repo ghrepo.Interface, limit int) ([]Workf`
`61`	`63`
`62`	`64`	`for _, workflow := range result.Workflows {`
`63`	`65`	`workflows = append(workflows, workflow)`
`64`		`- if len(workflows) == limit {`
	`66`	`+ if limit > 0 && len(workflows) == limit {`
`65`	`67`	`break`
`66`	`68`	`}`
`67`	`69`	`}`
`@@ -136,8 +138,7 @@ func getWorkflowByID(client api.Client, repo ghrepo.Interface, ID string) (Wor`
`136`	`138`	`}`
`137`	`139`
`138`	`140`	`func getWorkflowsByName(client *api.Client, repo ghrepo.Interface, name string) ([]Workflow, error) {`
`139`		`- // TODO fix limit`
`140`		`- workflows, err := GetWorkflows(client, repo, 100)`
	`141`	`+ workflows, err := GetWorkflows(client, repo, 0)`
`141`	`142`	`if err != nil {`
`142`	`143`	`return nil, fmt.Errorf("couldn't fetch workflows for %s: %w", ghrepo.FullName(repo), err)`
`143`	`144`	`}`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ func runView(opts *ViewOptions) error {`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`func promptWorkflows(client api.Client, repo ghrepo.Interface) (shared.Workflow, error) {`
`179`		`- workflows, err := shared.GetWorkflows(client, repo, 10)`
	`179`	`+ workflows, err := shared.GetWorkflows(client, repo, 0)`
`180`	`180`	`if len(workflows) == 0 {`
`181`	`181`	`err = errors.New("no workflows are enabled")`
`182`	`182`	`}`