Add tests for pr status reviews and checks output

mislav · mislav · commit 9ddd50ffa912 · 2019-12-19T17:37:57.000+01:00
diff --git a/api/queries_pr.go b/api/queries_pr.go
@@ -126,10 +126,6 @@ func PullRequests(client *Client, ghRepo Repo, currentPRNumber int, currentPRHea
 		Edges []struct {
 			Node PullRequest
 		}
-		PageInfo struct {
-			HasNextPage bool
-			EndCursor   string
-		}
 	}
 
 	type response struct {
@@ -207,19 +203,13 @@ func PullRequests(client *Client, ghRepo Repo, currentPRNumber int, currentPRHea
             ...prWithReviews
           }
         }
-        pageInfo {
-          hasNextPage
-        }
       }
       reviewRequested: search(query: $reviewerQuery, type: ISSUE, first: $per_page) {
         edges {
           node {
             ...pr
           }
         }
-        pageInfo {
-          hasNextPage
-        }
       }
     }
 	`
diff --git a/command/pr_test.go b/command/pr_test.go
@@ -95,6 +95,32 @@ func TestPRStatus(t *testing.T) {
 	}
 }
 
+func TestPRStatus_reviewsAndChecks(t *testing.T) {
+	initBlankContext("OWNER/REPO", "blueberries")
+	http := initFakeHTTP()
+
+	jsonFile, _ := os.Open("../test/fixtures/prStatusChecks.json")
+	defer jsonFile.Close()
+	http.StubResponse(200, jsonFile)
+
+	output, err := RunCommand(prStatusCmd, "pr status")
+	if err != nil {
+		t.Errorf("error running command `pr status`: %v", err)
+	}
+
+	expected := []string{
+		"- Checks passing - changes requested",
+		"- Checks pending - approved",
+		"- 1/3 checks failing - review required",
+	}
+
+	for _, line := range expected {
+		if !strings.Contains(output.String(), line) {
+			t.Errorf("output did not contain %q: %q", line, output.String())
+		}
+	}
+}
+
 func TestPRStatus_blankSlate(t *testing.T) {
 	initBlankContext("OWNER/REPO", "blueberries")
 	http := initFakeHTTP()
diff --git a/test/fixtures/prStatus.json b/test/fixtures/prStatus.json
@@ -27,8 +27,7 @@
           "headRefName": "strawberries"
         }
       }
-    ],
-    "pageInfo": { "hasNextPage": false }
+    ]
   },
   "reviewRequested": {
     "edges": [
@@ -48,7 +47,6 @@
           "headRefName": "figs"
         }
       }
-    ],
-    "pageInfo": { "hasNextPage": false }
+    ]
   }
 }}
diff --git a/test/fixtures/prStatusChecks.json b/test/fixtures/prStatusChecks.json
@@ -0,0 +1,93 @@
+{
+  "data":{
+    "repository": {
+      "pullRequests": {
+        "edges": []
+      }
+    },
+    "viewerCreated": {
+      "edges": [
+        {
+          "node": {
+            "number": 8,
+            "title": "Strawberries are not actually berries",
+            "url": "https://github.com/github/gh-cli/pull/8",
+            "headRefName": "strawberries",
+            "reviewDecision": "CHANGES_REQUESTED",
+            "commits": {
+              "nodes": [{
+                "commit": {
+                  "statusCheckRollup": {
+                    "contexts": {
+                      "nodes": [{
+                        "state": "SUCCESS"
+                      }]
+                    }
+                  }
+                }
+              }]
+            }
+          }
+        },
+        {
+          "node": {
+            "number": 7,
+            "title": "Bananas are berries",
+            "url": "https://github.com/github/gh-cli/pull/7",
+            "headRefName": "banananana",
+            "reviewDecision": "APPROVED",
+            "commits": {
+              "nodes": [{
+                "commit": {
+                  "statusCheckRollup": {
+                    "contexts": {
+                      "nodes": [{
+                        "status": "IN_PROGRESS",
+                        "conclusion": ""
+                      }]
+                    }
+                  }
+                }
+              }]
+            }
+          }
+        },
+        {
+          "node": {
+            "number": 6,
+            "title": "Avocado is probably not a berry",
+            "url": "https://github.com/github/gh-cli/pull/6",
+            "headRefName": "avo",
+            "reviewDecision": "REVIEW_REQUIRED",
+            "commits": {
+              "nodes": [{
+                "commit": {
+                  "statusCheckRollup": {
+                    "contexts": {
+                      "nodes": [
+                        {
+                          "status": "IN_PROGRESS",
+                          "conclusion": ""
+                        },
+                        {
+                          "state": "FAILURE"
+                        },
+                        {
+                          "status": "COMPLETED",
+                          "conclusion": "NEUTRAL"
+                        }
+                      ]
+                    }
+                  }
+                }
+              }]
+            }
+          }
+        }
+      ]
+    },
+    "reviewRequested": {
+      "edges": []
+    }
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -126,10 +126,6 @@ func PullRequests(client *Client, ghRepo Repo, currentPRNumber int, currentPRHea`
`126`	`126`	`Edges []struct {`
`127`	`127`	`Node PullRequest`
`128`	`128`	`}`
`129`		`- PageInfo struct {`
`130`		`- HasNextPage bool`
`131`		`- EndCursor string`
`132`		`- }`
`133`	`129`	`}`
`134`	`130`
`135`	`131`	`type response struct {`
`@@ -207,19 +203,13 @@ func PullRequests(client *Client, ghRepo Repo, currentPRNumber int, currentPRHea`
`207`	`203`	`...prWithReviews`
`208`	`204`	`}`
`209`	`205`	`}`
`210`		`- pageInfo {`
`211`		`- hasNextPage`
`212`		`- }`
`213`	`206`	`}`
`214`	`207`	`reviewRequested: search(query: $reviewerQuery, type: ISSUE, first: $per_page) {`
`215`	`208`	`edges {`
`216`	`209`	`node {`
`217`	`210`	`...pr`
`218`	`211`	`}`
`219`	`212`	`}`
`220`		`- pageInfo {`
`221`		`- hasNextPage`
`222`		`- }`
`223`	`213`	`}`
`224`	`214`	`}`
`225`	`215`	`
Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,7 @@`
`27`	`27`	`"headRefName": "strawberries"`
`28`	`28`	`}`
`29`	`29`	`}`
`30`		`- ],`
`31`		`- "pageInfo": { "hasNextPage": false }`
	`30`	`+ ]`
`32`	`31`	`},`
`33`	`32`	`"reviewRequested": {`
`34`	`33`	`"edges": [`
`@@ -48,7 +47,6 @@`
`48`	`47`	`"headRefName": "figs"`
`49`	`48`	`}`
`50`	`49`	`}`
`51`		`- ],`
`52`		`- "pageInfo": { "hasNextPage": false }`
	`50`	`+ ]`
`53`	`51`	`}`
`54`	`52`	`}}`