Disable pager when set to "cat"

tgyurci · tgyurci · commit 9b2fe1ee3097 · 2020-09-29T23:21:59.000+02:00
diff --git a/internal/config/config_type.go b/internal/config/config_type.go
@@ -181,7 +181,7 @@ func NewBlankRoot() *yaml.Node {
 						Value: PromptsEnabled,
 					},
 					{
-						HeadComment: "A pager program to send command output to. Example value: less",
+						HeadComment: "A pager program to send command output to, e.g. \"less\". Set the value to \"cat\" to disable the pager.",
 						Kind:        yaml.ScalarNode,
 						Value:       "pager",
 					},
diff --git a/internal/config/config_type_test.go b/internal/config/config_type_test.go
@@ -45,7 +45,7 @@ func Test_defaultConfig(t *testing.T) {
 		editor:
 		# When to interactively prompt. This is a global config that cannot be overridden by hostname. Supported values: enabled, disabled
 		prompt: enabled
-		# A pager program to send command output to. Example value: less
+		# A pager program to send command output to, e.g. "less". Set the value to "cat" to disable the pager.
 		pager:
 		# Aliases allow you to create nicknames for gh commands
 		aliases:
diff --git a/pkg/iostreams/iostreams.go b/pkg/iostreams/iostreams.go
@@ -138,7 +138,7 @@ func (s *IOStreams) SetPager(cmd string) {
 }
 
 func (s *IOStreams) StartPager() error {
-	if s.pagerCommand == "" || !s.IsStdoutTTY() {
+	if s.pagerCommand == "" || s.pagerCommand == "cat" || !s.IsStdoutTTY() {
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ func NewBlankRoot() *yaml.Node {`
`181`	`181`	`Value: PromptsEnabled,`
`182`	`182`	`},`
`183`	`183`	`{`
`184`		`- HeadComment: "A pager program to send command output to. Example value: less",`
	`184`	`+ HeadComment: "A pager program to send command output to, e.g. \"less\". Set the value to \"cat\" to disable the pager.",`
`185`	`185`	`Kind: yaml.ScalarNode,`
`186`	`186`	`Value: "pager",`
`187`	`187`	`},`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ func (s *IOStreams) SetPager(cmd string) {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`func (s *IOStreams) StartPager() error {`
`141`		`- if s.pagerCommand == "" \|\| !s.IsStdoutTTY() {`
	`141`	`+ if s.pagerCommand == "" \|\| s.pagerCommand == "cat" \|\| !s.IsStdoutTTY() {`
`142`	`142`	`return nil`
`143`	`143`	`}`
`144`	`144`