Add consts for targets and treat empty as prod

actions-user · actions-user · commit 94128d683c62 · 2022-03-10T19:59:24.000-06:00
diff --git a/internal/codespaces/api/api.go b/internal/codespaces/api/api.go
@@ -52,6 +52,13 @@ const (
 	vscsAPI      = "https://online.visualstudio.com"
 )
 
+const (
+	VSCSTargetLocal       = "local"
+	VSCSTargetDevelopment = "development"
+	VSCSTargetPPE         = "ppe"
+	VSCSTargetProduction  = "production"
+)
+
 // API is the interface to the codespace service.
 type API struct {
 	client       httpClient
diff --git a/pkg/cmd/codespace/list.go b/pkg/cmd/codespace/list.go
@@ -45,8 +45,9 @@ func (a *App) List(ctx context.Context, limit int, exporter cmdutil.Exporter) er
 
 	hasNonProdVSCSTarget := false
 	for _, apiCodespace := range codespaces {
-		if apiCodespace.VSCSTarget != "prod" {
+		if apiCodespace.VSCSTarget != "" && apiCodespace.VSCSTarget != api.VSCSTargetProduction {
 			hasNonProdVSCSTarget = true
+			break
 		}
 	}
 
@@ -114,11 +115,11 @@ func (a *App) List(ctx context.Context, limit int, exporter cmdutil.Exporter) er
 }
 
 func formatNameForVSCSTarget(name, vscsTarget string) string {
-	if vscsTarget == "dev" || vscsTarget == "local" {
+	if vscsTarget == api.VSCSTargetDevelopment || vscsTarget == api.VSCSTargetLocal {
 		return fmt.Sprintf("%s 🚧", name)
 	}
 
-	if vscsTarget == "ppe" {
+	if vscsTarget == api.VSCSTargetPPE {
 		return fmt.Sprintf("%s ✨", name)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,9 @@ func (a *App) List(ctx context.Context, limit int, exporter cmdutil.Exporter) er`
`45`	`45`
`46`	`46`	`hasNonProdVSCSTarget := false`
`47`	`47`	`for _, apiCodespace := range codespaces {`
`48`		`- if apiCodespace.VSCSTarget != "prod" {`
	`48`	`+ if apiCodespace.VSCSTarget != "" && apiCodespace.VSCSTarget != api.VSCSTargetProduction {`
`49`	`49`	`hasNonProdVSCSTarget = true`
	`50`	`+ break`
`50`	`51`	`}`
`51`	`52`	`}`
`52`	`53`
`@@ -114,11 +115,11 @@ func (a *App) List(ctx context.Context, limit int, exporter cmdutil.Exporter) er`
`114`	`115`	`}`
`115`	`116`
`116`	`117`	`func formatNameForVSCSTarget(name, vscsTarget string) string {`
`117`		`- if vscsTarget == "dev" \|\| vscsTarget == "local" {`
	`118`	`+ if vscsTarget == api.VSCSTargetDevelopment \|\| vscsTarget == api.VSCSTargetLocal {`
`118`	`119`	`return fmt.Sprintf("%s 🚧", name)`
`119`	`120`	`}`
`120`	`121`
`121`		`- if vscsTarget == "ppe" {`
	`122`	`+ if vscsTarget == api.VSCSTargetPPE {`
`122`	`123`	`return fmt.Sprintf("%s ✨", name)`
`123`	`124`	`}`
`124`	`125`