Return errors in ask stubber instead of panicking

mislav · mislav · commit 8e64c149e155 · 2022-01-13T11:58:58.000+01:00
diff --git a/pkg/prompt/stubber.go b/pkg/prompt/stubber.go
@@ -41,7 +41,7 @@ func InitAskStubber() (*AskStubber, func()) {
 			message = pt.Message
 			defaultValue = pt.Default
 		default:
-			panic(fmt.Sprintf("prompt type %T is not supported by the stubber", pt))
+			return fmt.Errorf("prompt type %T is not supported by the stubber", pt)
 		}
 
 		var stub *QuestionStub
@@ -53,12 +53,12 @@ func InitAskStubber() (*AskStubber, func()) {
 			}
 		}
 		if stub == nil {
-			panic(fmt.Sprintf("no prompt stub for %q", message))
+			return fmt.Errorf("no prompt stub for %q", message)
 		}
 
 		if len(stub.options) > 0 {
 			if err := compareOptions(stub.options, options); err != nil {
-				panic(fmt.Sprintf("options mismatch for %q: %v", message, err))
+				return fmt.Errorf("stubbed options mismatch for %q: %v", message, err)
 			}
 		}
 
@@ -73,7 +73,7 @@ func InitAskStubber() (*AskStubber, func()) {
 				}
 			}
 			if foundIndex < 0 {
-				panic(fmt.Sprintf("answer %q not found in options for %q: %v", stringValue, message, options))
+				return fmt.Errorf("answer %q not found in options for %q: %v", stringValue, message, options)
 			}
 			userValue = core.OptionAnswer{
 				Value: stringValue,

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func InitAskStubber() (*AskStubber, func()) {`
`41`	`41`	`message = pt.Message`
`42`	`42`	`defaultValue = pt.Default`
`43`	`43`	`default:`
`44`		`- panic(fmt.Sprintf("prompt type %T is not supported by the stubber", pt))`
	`44`	`+ return fmt.Errorf("prompt type %T is not supported by the stubber", pt)`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`var stub *QuestionStub`
`@@ -53,12 +53,12 @@ func InitAskStubber() (*AskStubber, func()) {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`	`if stub == nil {`
`56`		`- panic(fmt.Sprintf("no prompt stub for %q", message))`
	`56`	`+ return fmt.Errorf("no prompt stub for %q", message)`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`if len(stub.options) > 0 {`
`60`	`60`	`if err := compareOptions(stub.options, options); err != nil {`
`61`		`- panic(fmt.Sprintf("options mismatch for %q: %v", message, err))`
	`61`	`+ return fmt.Errorf("stubbed options mismatch for %q: %v", message, err)`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`@@ -73,7 +73,7 @@ func InitAskStubber() (*AskStubber, func()) {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`	`if foundIndex < 0 {`
`76`		`- panic(fmt.Sprintf("answer %q not found in options for %q: %v", stringValue, message, options))`
	`76`	`+ return fmt.Errorf("answer %q not found in options for %q: %v", stringValue, message, options)`
`77`	`77`	`}`
`78`	`78`	`userValue = core.OptionAnswer{`
`79`	`79`	`Value: stringValue,`