Add a note about the dummy GHE hostname

mislav · mislav · commit 82c6fb7d1a33 · 2021-07-26T18:59:53.000+02:00
diff --git a/pkg/cmd/factory/remote_resolver.go b/pkg/cmd/factory/remote_resolver.go
@@ -80,9 +80,10 @@ func (rr *remoteResolver) Resolver() func() (context.Remotes, error) {
 		}
 
 		if len(cachedRemotes) == 0 {
+			dummyHostname := "example.com" // any non-github.com hostname is fine here
 			if config.IsHostEnv(src) {
 				return nil, fmt.Errorf("none of the git remotes configured for this repository correspond to the %s environment variable. Try adding a matching remote or unsetting the variable.", src)
-			} else if v, src, _ := cfg.GetWithSource("example.com", "oauth_token"); v != "" && config.IsEnterpriseEnv(src) {
+			} else if v, src, _ := cfg.GetWithSource(dummyHostname, "oauth_token"); v != "" && config.IsEnterpriseEnv(src) {
 				return nil, errors.New("set the GH_HOST environment variable to specify which GitHub host to use")
 			}
 			return nil, errors.New("none of the git remotes configured for this repository point to a known GitHub host. To tell gh about a new GitHub host, please use `gh auth login`")

Original file line number	Diff line number	Diff line change
`@@ -80,9 +80,10 @@ func (rr *remoteResolver) Resolver() func() (context.Remotes, error) {`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`if len(cachedRemotes) == 0 {`
	`83`	`+ dummyHostname := "example.com" // any non-github.com hostname is fine here`
`83`	`84`	`if config.IsHostEnv(src) {`
`84`	`85`	`return nil, fmt.Errorf("none of the git remotes configured for this repository correspond to the %s environment variable. Try adding a matching remote or unsetting the variable.", src)`
`85`		`- } else if v, src, _ := cfg.GetWithSource("example.com", "oauth_token"); v != "" && config.IsEnterpriseEnv(src) {`
	`86`	`+ } else if v, src, _ := cfg.GetWithSource(dummyHostname, "oauth_token"); v != "" && config.IsEnterpriseEnv(src) {`
`86`	`87`	`return nil, errors.New("set the GH_HOST environment variable to specify which GitHub host to use")`
`87`	`88`	`}`
`88`	`89`	return nil, errors.New("none of the git remotes configured for this repository point to a known GitHub host. To tell gh about a new GitHub host, please use `gh auth login`")