Update docs, simplify loop to append to command

josebalius · josebalius · commit 76037ee75367 · 2021-09-17T13:54:00.000-04:00
diff --git a/internal/codespaces/ssh.go b/internal/codespaces/ssh.go
@@ -64,16 +64,11 @@ func newSSHCommand(ctx context.Context, port int, dst string, cmdArgs []string)
 	return cmd, connArgs, nil
 }
 
-// parseSSHArgs parses SSH arguments into two distinct slices of flags
-// and command. It returns an error if flags are found after a command
-// or if a unary flag is provided without an argument.
+// parseSSHArgs parses SSH arguments into two distinct slices of flags and command.
+// It returns an error if a unary flag is provided without an argument.
 func parseSSHArgs(args []string) (cmdArgs []string, command []string, err error) {
 	for i := 0; i < len(args); i++ {
 		arg := args[i]
-		if command != nil {
-			command = append(command, arg)
-			continue
-		}
 
 		if strings.HasPrefix(arg, "-") {
 			cmdArgs = append(cmdArgs, arg)
@@ -84,9 +79,12 @@ func parseSSHArgs(args []string) (cmdArgs []string, command []string, err error)
 
 				cmdArgs = append(cmdArgs, args[i])
 			}
-		} else {
-			command = append(command, arg)
+			continue
 		}
+
+		// if we've started parsing the command, append all further args to it
+		command = append(command, args[i:]...)
+		break
 	}
 
 	return cmdArgs, command, nil
diff --git a/internal/codespaces/ssh_test.go b/internal/codespaces/ssh_test.go
@@ -69,7 +69,7 @@ func TestParseSSHArgs(t *testing.T) {
 
 	for _, tcase := range testCases {
 		args, command, err := parseSSHArgs(tcase.Args)
-		if err != nil && !tcase.Error {
+		if !tcase.Error && err != nil {
 			t.Errorf("unexpected error: %v on test case: %#v", err, tcase)
 			continue
 		}

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ func TestParseSSHArgs(t *testing.T) {`
`69`	`69`
`70`	`70`	`for _, tcase := range testCases {`
`71`	`71`	`args, command, err := parseSSHArgs(tcase.Args)`
`72`		`- if err != nil && !tcase.Error {`
	`72`	`+ if !tcase.Error && err != nil {`
`73`	`73`	`t.Errorf("unexpected error: %v on test case: %#v", err, tcase)`
`74`	`74`	`continue`
`75`	`75`	`}`