Add version to extension list command (cli#5219)

seachicken · web-flow · commit 6f66a1d265d1 · 2022-03-07T07:14:26.000Z
* Add version to extension list command

* Trim sha only when displaying
diff --git a/pkg/cmd/extension/command.go b/pkg/cmd/extension/command.go
@@ -61,6 +61,11 @@ func NewCmdExtension(f *cmdutil.Factory) *cobra.Command {
 
 					t.AddField(fmt.Sprintf("gh %s", c.Name()), nil, nil)
 					t.AddField(repo, nil, nil)
+					version := c.CurrentVersion()
+					if !c.IsBinary() && len(version) > 8 {
+						version = version[:8]
+					}
+					t.AddField(version, nil, nil)
 					var updateAvailable string
 					if c.UpdateAvailable() {
 						updateAvailable = "Upgrade available"
diff --git a/pkg/cmd/extension/command_test.go b/pkg/cmd/extension/command_test.go
@@ -299,7 +299,7 @@ func TestNewCmdExtension(t *testing.T) {
 					assert.Equal(t, 1, len(em.ListCalls()))
 				}
 			},
-			wantStdout: "gh test\tcli/gh-test\t\ngh test2\tcli/gh-test2\tUpgrade available\n",
+			wantStdout: "gh test\tcli/gh-test\t1\t\ngh test2\tcli/gh-test2\t1\tUpgrade available\n",
 		},
 		{
 			name: "create extension interactive",
diff --git a/pkg/cmd/extension/extension.go b/pkg/cmd/extension/extension.go
@@ -39,6 +39,10 @@ func (e *Extension) IsLocal() bool {
 	return e.isLocal
 }
 
+func (e *Extension) CurrentVersion() string {
+	return e.currentVersion
+}
+
 func (e *Extension) UpdateAvailable() bool {
 	if e.isLocal ||
 		e.currentVersion == "" ||
diff --git a/pkg/extensions/extension.go b/pkg/extensions/extension.go
@@ -20,6 +20,7 @@ type Extension interface {
 	Path() string // Path to executable
 	URL() string
 	IsLocal() bool
+	CurrentVersion() string
 	UpdateAvailable() bool
 	IsBinary() bool
 }
diff --git a/pkg/extensions/extension_mock.go b/pkg/extensions/extension_mock.go

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ func TestNewCmdExtension(t *testing.T) {`
`299`	`299`	`assert.Equal(t, 1, len(em.ListCalls()))`
`300`	`300`	`}`
`301`	`301`	`},`
`302`		`- wantStdout: "gh test\tcli/gh-test\t\ngh test2\tcli/gh-test2\tUpgrade available\n",`
	`302`	`+ wantStdout: "gh test\tcli/gh-test\t1\t\ngh test2\tcli/gh-test2\t1\tUpgrade available\n",`
`303`	`303`	`},`
`304`	`304`	`{`
`305`	`305`	`name: "create extension interactive",`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ type Extension interface {`
`20`	`20`	`Path() string // Path to executable`
`21`	`21`	`URL() string`
`22`	`22`	`IsLocal() bool`
	`23`	`+ CurrentVersion() string`
`23`	`24`	`UpdateAvailable() bool`
`24`	`25`	`IsBinary() bool`
`25`	`26`	`}`