Disable auth for cobra shell request completion hidden commands

cuonglm · cuonglm · commit 6cf6bb4a4445 · 2021-08-25T01:35:49.000+07:00
Those hidden command are used by the shell completion scripts, but they are not disabled auth check. Thus, the shell completion does not work even the completion setup was done properly. Fixes cli#4188
diff --git a/pkg/cmdutil/auth_check.go b/pkg/cmdutil/auth_check.go
@@ -34,9 +34,11 @@ func CheckAuth(cfg config.Config) bool {
 }
 
 func IsAuthCheckEnabled(cmd *cobra.Command) bool {
-	if cmd.Name() == "help" {
+	switch cmd.Name() {
+	case "help", cobra.ShellCompRequestCmd, cobra.ShellCompNoDescRequestCmd:
 		return false
 	}
+
 	for c := cmd; c.Parent() != nil; c = c.Parent() {
 		if c.Annotations != nil && c.Annotations["skipAuthCheck"] == "true" {
 			return false

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,11 @@ func CheckAuth(cfg config.Config) bool {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`func IsAuthCheckEnabled(cmd *cobra.Command) bool {`
`37`		`- if cmd.Name() == "help" {`
	`37`	`+ switch cmd.Name() {`
	`38`	`+ case "help", cobra.ShellCompRequestCmd, cobra.ShellCompNoDescRequestCmd:`
`38`	`39`	`return false`
`39`	`40`	`}`
	`41`	`+`
`40`	`42`	`for c := cmd; c.Parent() != nil; c = c.Parent() {`
`41`	`43`	`if c.Annotations != nil && c.Annotations["skipAuthCheck"] == "true" {`
`42`	`44`	`return false`