Support ghost reviews in pr view

doi-t · doi-t · commit 67907c8b004f · 2020-04-22T21:59:09.000+09:00
diff --git a/command/pr.go b/command/pr.go
@@ -434,14 +434,20 @@ func prReviewerList(pr api.PullRequest) string {
 // Ref. https://developer.github.com/v4/union/requestedreviewer/
 const teamTypeName = "Team"
 
+const ghostName = "ghost"
+
 // parseReviewers parses given Reviews and ReviewRequests
 func parseReviewers(pr api.PullRequest) []*reviewerState {
 	reviewerStates := make(map[string]*reviewerState)
 
 	for _, review := range pr.Reviews.Nodes {
 		if review.Author.Login != pr.Author.Login {
-			reviewerStates[review.Author.Login] = &reviewerState{
-				Name:  review.Author.Login,
+			name := review.Author.Login
+			if name == "" {
+				name = ghostName
+			}
+			reviewerStates[name] = &reviewerState{
+				Name:  name,
 				State: review.State,
 			}
 		}
diff --git a/command/pr_test.go b/command/pr_test.go
@@ -442,7 +442,7 @@ func TestPRView_Preview(t *testing.T) {
 			fixture:   "../test/fixtures/prViewPreviewWithReviewersByNumber.json",
 			expectedOutputs: []string{
 				`Blueberries are from a fork`,
-				`Reviewers: DEF \(Commented\), def \(Changes requested\), xyz \(Approved\), 123 \(Requested\), Team 1 \(Requested\), abc \(Requested\)\n`,
+				`Reviewers: DEF \(Commented\), def \(Changes requested\), ghost \(Approved\), xyz \(Approved\), 123 \(Requested\), Team 1 \(Requested\), abc \(Requested\)\n`,
 				`blueberries taste good`,
 				`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12\n`,
 			},
diff --git a/test/fixtures/prViewPreviewWithReviewersByNumber.json b/test/fixtures/prViewPreviewWithReviewersByNumber.json
@@ -64,6 +64,12 @@
                 "login": "xyz"
               },
               "state": "APPROVED"
+            },
+            {
+              "author": {
+                "login": ""
+              },
+              "state": "APPROVED"
             }
           ]
         },

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,12 @@`
`64`	`64`	`"login": "xyz"`
`65`	`65`	`},`
`66`	`66`	`"state": "APPROVED"`
	`67`	`+ },`
	`68`	`+ {`
	`69`	`+ "author": {`
	`70`	`+ "login": ""`
	`71`	`+ },`
	`72`	`+ "state": "APPROVED"`
`67`	`73`	`}`
`68`	`74`	`]`
`69`	`75`	`},`