Warn about repo issues disabled on issue create

mislav · mislav · commit 66534e504b0f · 2019-12-19T15:44:20.000+01:00
diff --git a/api/queries_issue.go b/api/queries_issue.go
@@ -42,11 +42,15 @@ const fragments = `
 `
 
 func IssueCreate(client *Client, ghRepo Repo, params map[string]interface{}) (*Issue, error) {
-	repoID, err := GitHubRepoId(client, ghRepo)
+	repo, err := GitHubRepo(client, ghRepo)
 	if err != nil {
 		return nil, err
 	}
 
+	if !repo.HasIssuesEnabled {
+		return nil, fmt.Errorf("the '%s/%s' repository has disabled issues", ghRepo.RepoOwner(), ghRepo.RepoName())
+	}
+
 	query := `
 	mutation CreateIssue($input: CreateIssueInput!) {
 		createIssue(input: $input) {
@@ -57,7 +61,7 @@ func IssueCreate(client *Client, ghRepo Repo, params map[string]interface{}) (*I
 	}`
 
 	inputParams := map[string]interface{}{
-		"repositoryId": repoID,
+		"repositoryId": repo.ID,
 	}
 	for key, val := range params {
 		inputParams[key] = val
diff --git a/api/queries_pr.go b/api/queries_pr.go
@@ -376,7 +376,7 @@ func PullRequestForBranch(client *Client, ghRepo Repo, branch string) (*PullRequ
 }
 
 func CreatePullRequest(client *Client, ghRepo Repo, params map[string]interface{}) (*PullRequest, error) {
-	repoID, err := GitHubRepoId(client, ghRepo)
+	repo, err := GitHubRepo(client, ghRepo)
 	if err != nil {
 		return nil, err
 	}
@@ -391,7 +391,7 @@ func CreatePullRequest(client *Client, ghRepo Repo, params map[string]interface{
 	}`
 
 	inputParams := map[string]interface{}{
-		"repositoryId": repoID,
+		"repositoryId": repo.ID,
 	}
 	for key, val := range params {
 		inputParams[key] = val
diff --git a/api/queries_repo.go b/api/queries_repo.go
@@ -1,31 +1,46 @@
 package api
 
-import "fmt"
+import (
+	"fmt"
 
-func GitHubRepoId(client *Client, ghRepo Repo) (string, error) {
+	"github.com/pkg/errors"
+)
+
+// Repository contains information about a GitHub repo
+type Repository struct {
+	ID               string
+	HasIssuesEnabled bool
+}
+
+// GitHubRepo looks up the node ID of a named repository
+func GitHubRepo(client *Client, ghRepo Repo) (*Repository, error) {
 	owner := ghRepo.RepoOwner()
 	repo := ghRepo.RepoName()
 
 	query := `
-		query FindRepoID($owner:String!, $name:String!) {
-			repository(owner:$owner, name:$name) {
-				id
-			}
+	query($owner: String!, $name: String!) {
+		repository(owner: $owner, name: $name) {
+			id
+			hasIssuesEnabled
+		}
 	}`
 	variables := map[string]interface{}{
 		"owner": owner,
 		"name":  repo,
 	}
 
 	result := struct {
-		Repository struct {
-			Id string
-		}
+		Repository Repository
 	}{}
 	err := client.GraphQL(query, variables, &result)
-	if err != nil || result.Repository.Id == "" {
-		return "", fmt.Errorf("failed to determine GH repo ID: %s", err)
+
+	if err != nil || result.Repository.ID == "" {
+		newErr := fmt.Errorf("failed to determine repository ID for '%s/%s'", owner, repo)
+		if err != nil {
+			newErr = errors.Wrap(err, newErr.Error())
+		}
+		return nil, newErr
 	}
 
-	return result.Repository.Id, nil
+	return &result.Repository, nil
 }
diff --git a/command/issue_test.go b/command/issue_test.go
@@ -231,7 +231,8 @@ func TestIssueCreate(t *testing.T) {
 
 	http.StubResponse(200, bytes.NewBufferString(`
 		{ "data": { "repository": {
-			"id": "REPOID"
+			"id": "REPOID",
+			"hasIssuesEnabled": true
 		} } }
 	`))
 	http.StubResponse(200, bytes.NewBufferString(`

Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@ func PullRequestForBranch(client Client, ghRepo Repo, branch string) (PullRequ`
`376`	`376`	`}`
`377`	`377`
`378`	`378`	`func CreatePullRequest(client Client, ghRepo Repo, params map[string]interface{}) (PullRequest, error) {`
`379`		`- repoID, err := GitHubRepoId(client, ghRepo)`
	`379`	`+ repo, err := GitHubRepo(client, ghRepo)`
`380`	`380`	`if err != nil {`
`381`	`381`	`return nil, err`
`382`	`382`	`}`
`@@ -391,7 +391,7 @@ func CreatePullRequest(client *Client, ghRepo Repo, params map[string]interface{`
`391`	`391`	}`
`392`	`392`
`393`	`393`	`inputParams := map[string]interface{}{`
`394`		`- "repositoryId": repoID,`
	`394`	`+ "repositoryId": repo.ID,`
`395`	`395`	`}`
`396`	`396`	`for key, val := range params {`
`397`	`397`	`inputParams[key] = val`