Fix crash in issue/pr list for narrow terminals

mislav · mislav · commit 61ff5d73bd89 · 2020-02-18T20:03:09.000+01:00
If the available column width is smaller than 3, don't try to truncate
with ellipsis (`...`). Instead, just truncate to available width.
diff --git a/utils/table_printer.go b/utils/table_printer.go
@@ -176,7 +176,10 @@ func (t *tsvTablePrinter) Render() error {
 
 func truncate(maxLength int, title string) string {
 	if len(title) > maxLength {
-		return title[0:maxLength-3] + "..."
+		if maxLength > 3 {
+			return title[0:maxLength-3] + "..."
+		}
+		return title[0:maxLength]
 	}
 	return title
 }
diff --git a/utils/table_printer_test.go b/utils/table_printer_test.go
@@ -0,0 +1,31 @@
+package utils
+
+import (
+	"bytes"
+	"testing"
+)
+
+func Test_ttyTablePrinter_truncate(t *testing.T) {
+	buf := bytes.Buffer{}
+	tp := &ttyTablePrinter{
+		out:      &buf,
+		maxWidth: 5,
+	}
+
+	tp.AddField("1", nil, nil)
+	tp.AddField("hello", nil, nil)
+	tp.EndRow()
+	tp.AddField("2", nil, nil)
+	tp.AddField("world", nil, nil)
+	tp.EndRow()
+
+	err := tp.Render()
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+
+	expected := "1  he\n2  wo\n"
+	if buf.String() != expected {
+		t.Errorf("expected: %q, got: %q", expected, buf.String())
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,10 @@ func (t *tsvTablePrinter) Render() error {`
`176`	`176`
`177`	`177`	`func truncate(maxLength int, title string) string {`
`178`	`178`	`if len(title) > maxLength {`
`179`		`- return title[0:maxLength-3] + "..."`
	`179`	`+ if maxLength > 3 {`
	`180`	`+ return title[0:maxLength-3] + "..."`
	`181`	`+ }`
	`182`	`+ return title[0:maxLength]`
`180`	`183`	`}`
`181`	`184`	`return title`
`182`	`185`	`}`