X Tutup
Skip to content

Commit 4a5ed81

Browse files
committed
Fix injecting version information into build from git
This was a typo. Note that Makefile is only used for building a development version after cloning from git; the tagged release process uses `.goreleaser.yml` and skips the Makefile.
1 parent 7bb2c38 commit 4a5ed81

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
BUILD_FILES = $(shell go list -f '{{range .GoFiles}}{{$$.Dir}}/{{.}}\
22
{{end}}' ./...)
33

4-
GH_VERSION = $(shell go describe --tags 2>/dev/null || git rev-parse --short HEAD)
4+
GH_VERSION = $(shell git describe --tags 2>/dev/null || git rev-parse --short HEAD)
55
LDFLAGS := -X github.com/github/gh-cli/command.Version=$(GH_VERSION) $(LDFLAGS)
66
LDFLAGS := -X github.com/github/gh-cli/command.BuildDate=$(shell date +%Y-%m-%d) $(LDFLAGS)
77
ifdef GH_OAUTH_CLIENT_SECRET

0 commit comments

Comments
 (0)
X Tutup