Allow retrying HTTP/2 uploads for release assets

mislav · mislav · commit 40da8f9c6919 · 2021-03-17T15:55:22.000+01:00
The `Request.GetBody` func allows the retry mechanism to reopen the file that's being uploaded as the request body in case the body of the previous request has already started to be read. Hopefully fixes the error: http2: Transport: cannot retry err [stream error: stream ID 1; REFUSED_STREAM] after Request.Body was written; define Request.GetBody to avoid this error Ref. https://github.com/golang/net/blob/d523dce5a7f4b994f7ed0531dbe44cd8fd803e26/http2/transport.go#L554
diff --git a/pkg/cmd/release/shared/upload.go b/pkg/cmd/release/shared/upload.go
@@ -170,6 +170,7 @@ func uploadAsset(httpClient *http.Client, uploadURL string, asset AssetForUpload
 	}
 	req.ContentLength = asset.Size
 	req.Header.Set("Content-Type", asset.MIMEType)
+	req.GetBody = asset.Open
 
 	resp, err := httpClient.Do(req)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,7 @@ func uploadAsset(httpClient *http.Client, uploadURL string, asset AssetForUpload`
`170`	`170`	`}`
`171`	`171`	`req.ContentLength = asset.Size`
`172`	`172`	`req.Header.Set("Content-Type", asset.MIMEType)`
	`173`	`+ req.GetBody = asset.Open`
`173`	`174`
`174`	`175`	`resp, err := httpClient.Do(req)`
`175`	`176`	`if err != nil {`