Update shouldCheckForUpdate

ShubhankarKG · ShubhankarKG · commit 3a22ab7eba19 · 2020-10-08T12:04:57.000+05:30
diff --git a/cmd/gh/main.go b/cmd/gh/main.go
@@ -186,7 +186,9 @@ func printError(out io.Writer, err error, cmd *cobra.Command, debug bool) {
 }
 
 func shouldCheckForUpdate() bool {
-	return updaterEnabled != "" && !isCompletionCommand() && utils.IsTerminal(os.Stderr)
+	isCIEnvironment := (os.Getenv("CI") != "") || (os.Getenv("BUILD_NUMBER") != "") || (os.Getenv("RUN_ID") != "")
+	isGlobalDisabled := os.Getenv("GH_NO_UPDATE_NOTIFIER") == "disabled"
+	return updaterEnabled != "" && !isCompletionCommand() && utils.IsTerminal(os.Stderr) && !isCIEnvironment && !isGlobalDisabled
 }
 
 func isCompletionCommand() bool {
diff --git a/internal/config/config_type.go b/internal/config/config_type.go
@@ -11,9 +11,11 @@ import (
 )
 
 const (
-	defaultGitProtocol = "https"
-	PromptsDisabled    = "disabled"
-	PromptsEnabled     = "enabled"
+	defaultGitProtocol  = "https"
+	PromptsDisabled     = "disabled"
+	PromptsEnabled      = "enabled"
+	UpdateCheckEnabled  = "enabled"
+	UpdateCheckDisabled = "disabled"
 )
 
 // This interface describes interacting with some persistent configuration for gh.

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,9 @@ func printError(out io.Writer, err error, cmd *cobra.Command, debug bool) {`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`func shouldCheckForUpdate() bool {`
`189`		`- return updaterEnabled != "" && !isCompletionCommand() && utils.IsTerminal(os.Stderr)`
	`189`	`+ isCIEnvironment := (os.Getenv("CI") != "") \|\| (os.Getenv("BUILD_NUMBER") != "") \|\| (os.Getenv("RUN_ID") != "")`
	`190`	`+ isGlobalDisabled := os.Getenv("GH_NO_UPDATE_NOTIFIER") == "disabled"`
	`191`	`+ return updaterEnabled != "" && !isCompletionCommand() && utils.IsTerminal(os.Stderr) && !isCIEnvironment && !isGlobalDisabled`
`190`	`192`	`}`
`191`	`193`
`192`	`194`	`func isCompletionCommand() bool {`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,11 @@ import (`
`11`	`11`	`)`
`12`	`12`
`13`	`13`	`const (`
`14`		`- defaultGitProtocol = "https"`
`15`		`- PromptsDisabled = "disabled"`
`16`		`- PromptsEnabled = "enabled"`
	`14`	`+ defaultGitProtocol = "https"`
	`15`	`+ PromptsDisabled = "disabled"`
	`16`	`+ PromptsEnabled = "enabled"`
	`17`	`+ UpdateCheckEnabled = "enabled"`
	`18`	`+ UpdateCheckDisabled = "disabled"`
`17`	`19`	`)`
`18`	`20`
`19`	`21`	`// This interface describes interacting with some persistent configuration for gh.`