Simplify logic a bit

samcoe · samcoe · commit 39f21ad7482b · 2022-03-30T08:41:00.000+02:00
diff --git a/pkg/cmd/pr/shared/params.go b/pkg/cmd/pr/shared/params.go
@@ -228,23 +228,23 @@ func SearchQueryBuild(options FilterOptions) string {
 }
 
 func splitKeywords(keywords string) []string {
-	a := []string{}
+	ks := []string{}
 	sb := &strings.Builder{}
 	quoted := false
 	for _, r := range keywords {
-		if r == '"' || r == '\'' {
+		if r == '"' {
 			quoted = !quoted
 		} else if !quoted && r == ' ' {
-			a = append(a, sb.String())
+			ks = append(ks, sb.String())
 			sb.Reset()
 		} else {
 			sb.WriteRune(r)
 		}
 	}
 	if sb.Len() > 0 {
-		a = append(a, sb.String())
+		ks = append(ks, sb.String())
 	}
-	return a
+	return ks
 }
 
 func QueryHasStateClause(searchQuery string) bool {

Original file line number	Diff line number	Diff line change
`@@ -228,23 +228,23 @@ func SearchQueryBuild(options FilterOptions) string {`
`228`	`228`	`}`
`229`	`229`
`230`	`230`	`func splitKeywords(keywords string) []string {`
`231`		`- a := []string{}`
	`231`	`+ ks := []string{}`
`232`	`232`	`sb := &strings.Builder{}`
`233`	`233`	`quoted := false`
`234`	`234`	`for _, r := range keywords {`
`235`		`- if r == '"' \|\| r == '\'' {`
	`235`	`+ if r == '"' {`
`236`	`236`	`quoted = !quoted`
`237`	`237`	`} else if !quoted && r == ' ' {`
`238`		`- a = append(a, sb.String())`
	`238`	`+ ks = append(ks, sb.String())`
`239`	`239`	`sb.Reset()`
`240`	`240`	`} else {`
`241`	`241`	`sb.WriteRune(r)`
`242`	`242`	`}`
`243`	`243`	`}`
`244`	`244`	`if sb.Len() > 0 {`
`245`		`- a = append(a, sb.String())`
	`245`	`+ ks = append(ks, sb.String())`
`246`	`246`	`}`
`247`		`- return a`
	`247`	`+ return ks`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`func QueryHasStateClause(searchQuery string) bool {`