explain why failure to connect to a codespace doesn't fail the entire command

znull · znull · commit 369ea534b67a · 2021-12-16T17:00:39.000-07:00
diff --git a/pkg/cmd/codespace/ssh.go b/pkg/cmd/codespace/ssh.go
@@ -212,6 +212,10 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions) error
 			session, err := openSSHSession(ctx, a, cs.Name, nil)
 			if err != nil {
 				fmt.Fprintf(os.Stderr, "error connecting to codespace: %v\n", err)
+
+				// Move on to the next codespace. We don't want to bail here - just because we're not
+				// able to set up connectivity to one doesn't mean we shouldn't make a best effort to
+				// generate configs for the rest of them.
 				continue
 			}
 			defer session.Close()
@@ -221,7 +225,7 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions) error
 			a.StopProgressIndicator()
 			if err != nil {
 				fmt.Fprintf(os.Stderr, "error getting ssh server details: %v", err)
-				continue
+				continue // see above
 			}
 			sshUsers[cs.Repository.FullName] = sshUser
 		}

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,10 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions) error`
`212`	`212`	`session, err := openSSHSession(ctx, a, cs.Name, nil)`
`213`	`213`	`if err != nil {`
`214`	`214`	`fmt.Fprintf(os.Stderr, "error connecting to codespace: %v\n", err)`
	`215`	`+`
	`216`	`+ // Move on to the next codespace. We don't want to bail here - just because we're not`
	`217`	`+ // able to set up connectivity to one doesn't mean we shouldn't make a best effort to`
	`218`	`+ // generate configs for the rest of them.`
`215`	`219`	`continue`
`216`	`220`	`}`
`217`	`221`	`defer session.Close()`
`@@ -221,7 +225,7 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions) error`
`221`	`225`	`a.StopProgressIndicator()`
`222`	`226`	`if err != nil {`
`223`	`227`	`fmt.Fprintf(os.Stderr, "error getting ssh server details: %v", err)`
`224`		`- continue`
	`228`	`+ continue // see above`
`225`	`229`	`}`
`226`	`230`	`sshUsers[cs.Repository.FullName] = sshUser`
`227`	`231`	`}`