context: use the real oauth credentials

urandom2 · mislav · commit 213f4a5333c2 · 2020-02-18T19:31:01.000+01:00
It is trivial to extract this information from the released artefacts,
thus there is no security benefit to the safe/development credentials.
This approach also prevents users from using go-get to install.

As proof of concept, and to enable go-get, this change embeds
the GitHub CLI credentials, instead of GitHub CLI (dev).
diff --git a/context/config_setup.go b/context/config_setup.go
@@ -18,10 +18,8 @@ const (
 )
 
 var (
-	// The GitHub app that is meant for development
-	oauthClientID = "4d747ba5675d5d66553f"
-	// This value is safe to be embedded in version control
-	oauthClientSecret = "d4fee7b3f9c2ef4284a5ca7be0ee200cf15b6f8d"
+	oauthClientID     = "178c6fc778ccc68e1d6a"
+	oauthClientSecret = "34ddeff2b558a23d38fba8a6de74f086ede1cc0b"
 )
 
 // TODO: have a conversation about whether this belongs in the "context" package

Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,8 @@ const (`
`18`	`18`	`)`
`19`	`19`
`20`	`20`	`var (`
`21`		`- // The GitHub app that is meant for development`
`22`		`- oauthClientID = "4d747ba5675d5d66553f"`
`23`		`- // This value is safe to be embedded in version control`
`24`		`- oauthClientSecret = "d4fee7b3f9c2ef4284a5ca7be0ee200cf15b6f8d"`
	`21`	`+ oauthClientID = "178c6fc778ccc68e1d6a"`
	`22`	`+ oauthClientSecret = "34ddeff2b558a23d38fba8a6de74f086ede1cc0b"`
`25`	`23`	`)`
`26`	`24`
`27`	`25`	`// TODO: have a conversation about whether this belongs in the "context" package`