Ensure that cache file is closed after reading

mislav · mislav · commit 1d435a3e2e05 · 2020-10-01T19:18:11.000+02:00
diff --git a/api/cache.go b/api/cache.go
@@ -84,11 +84,13 @@ func readCache(ttl time.Duration, cacheFile string, req *http.Request) (*http.Re
 	}
 
 	res, err := http.ReadResponse(bufio.NewReader(f), req)
-	if res != nil {
+	if res == nil {
 		res.Body = &readCloser{
 			Reader: res.Body,
 			Closer: f,
 		}
+	} else {
+		f.Close()
 	}
 	return res, err
 }

Original file line number	Diff line number	Diff line change
`@@ -84,11 +84,13 @@ func readCache(ttl time.Duration, cacheFile string, req http.Request) (http.Re`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`res, err := http.ReadResponse(bufio.NewReader(f), req)`
`87`		`- if res != nil {`
	`87`	`+ if res == nil {`
`88`	`88`	`res.Body = &readCloser{`
`89`	`89`	`Reader: res.Body,`
`90`	`90`	`Closer: f,`
`91`	`91`	`}`
	`92`	`+ } else {`
	`93`	`+ f.Close()`
`92`	`94`	`}`
`93`	`95`	`return res, err`
`94`	`96`	`}`