fix the route

ttran112 · ttran112 · commit 1a9704dbfb58 · 2021-06-05T22:46:46.000-07:00
diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go
@@ -31,7 +31,6 @@ type BrowseOptions struct {
 	WikiFlag     bool
 	SettingsFlag bool
 	BranchFlag   bool
-	//LineFlag     bool
 }
 
 type exitCode int
@@ -139,7 +138,6 @@ func openInBrowser(cmd *cobra.Command, opts *BrowseOptions) error {
 	}
 
 	return printExit(response, cmd, opts, repoUrl)
-
 }
 
 func addCombined(opts *BrowseOptions, url string, branchName string) (exitCode, string) {
@@ -158,7 +156,6 @@ func addCombined(opts *BrowseOptions, url string, branchName string) (exitCode,
 	}
 
 	return exitUrlSuccess, url + "/tree/" + opts.AdditionalArg + "/" + arr[0]
-
 }
 
 func addFlag(opts *BrowseOptions, url string) (exitCode, string) {
@@ -169,7 +166,7 @@ func addFlag(opts *BrowseOptions, url string) (exitCode, string) {
 	} else if opts.WikiFlag {
 		return exitUrlSuccess, url + "/wiki"
 	}
-	return exitExpectedArg, "" // Flag is a branch and needs an argument
+	return exitExpectedArg, ""
 }
 
 func addArg(opts *BrowseOptions, url string, branchName string) (exitCode, string) {
@@ -204,10 +201,8 @@ func printExit(exit exitCode, cmd *cobra.Command, opts *BrowseOptions, url strin
 	switch exit {
 	case exitUrlSuccess:
 		fmt.Fprintf(w, "now opening %s in browser . . .\n", cs.Bold(url))
-		break
 	case exitNonUrlSuccess:
 		fmt.Fprintf(w, "now opening issue/pr in browser . . .\n")
-		break
 	case exitNotInRepo:
 		return fmt.Errorf("change directory to a repository to open in browser\n%s", help)
 	case exitTooManyFlags:
diff --git a/pkg/cmd/root/root.go b/pkg/cmd/root/root.go
@@ -96,7 +96,7 @@ func NewCmdRoot(f *cmdutil.Factory, version, buildDate string) *cobra.Command {
 	repoResolvingCmdFactory := *f
 	repoResolvingCmdFactory.BaseRepo = resolvedBaseRepo(f)
 
-	cmd.AddCommand(browseCmd.NewCmdBrowse(f)) // adds to the commands Commands()
+	cmd.AddCommand(browseCmd.NewCmdBrowse(&repoResolvingCmdFactory)) // adds to the commands Commands()
 	cmd.AddCommand(prCmd.NewCmdPR(&repoResolvingCmdFactory))
 	cmd.AddCommand(issueCmd.NewCmdIssue(&repoResolvingCmdFactory))
 	cmd.AddCommand(releaseCmd.NewCmdRelease(&repoResolvingCmdFactory))

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ type BrowseOptions struct {`
`31`	`31`	`WikiFlag bool`
`32`	`32`	`SettingsFlag bool`
`33`	`33`	`BranchFlag bool`
`34`		`- //LineFlag bool`
`35`	`34`	`}`
`36`	`35`
`37`	`36`	`type exitCode int`
`@@ -139,7 +138,6 @@ func openInBrowser(cmd cobra.Command, opts BrowseOptions) error {`
`139`	`138`	`}`
`140`	`139`
`141`	`140`	`return printExit(response, cmd, opts, repoUrl)`
`142`		`-`
`143`	`141`	`}`
`144`	`142`
`145`	`143`	`func addCombined(opts *BrowseOptions, url string, branchName string) (exitCode, string) {`
`@@ -158,7 +156,6 @@ func addCombined(opts *BrowseOptions, url string, branchName string) (exitCode,`
`158`	`156`	`}`
`159`	`157`
`160`	`158`	`return exitUrlSuccess, url + "/tree/" + opts.AdditionalArg + "/" + arr[0]`
`161`		`-`
`162`	`159`	`}`
`163`	`160`
`164`	`161`	`func addFlag(opts *BrowseOptions, url string) (exitCode, string) {`
`@@ -169,7 +166,7 @@ func addFlag(opts *BrowseOptions, url string) (exitCode, string) {`
`169`	`166`	`} else if opts.WikiFlag {`
`170`	`167`	`return exitUrlSuccess, url + "/wiki"`
`171`	`168`	`}`
`172`		`- return exitExpectedArg, "" // Flag is a branch and needs an argument`
	`169`	`+ return exitExpectedArg, ""`
`173`	`170`	`}`
`174`	`171`
`175`	`172`	`func addArg(opts *BrowseOptions, url string, branchName string) (exitCode, string) {`
`@@ -204,10 +201,8 @@ func printExit(exit exitCode, cmd cobra.Command, opts BrowseOptions, url strin`
`204`	`201`	`switch exit {`
`205`	`202`	`case exitUrlSuccess:`
`206`	`203`	`fmt.Fprintf(w, "now opening %s in browser . . .\n", cs.Bold(url))`
`207`		`- break`
`208`	`204`	`case exitNonUrlSuccess:`
`209`	`205`	`fmt.Fprintf(w, "now opening issue/pr in browser . . .\n")`
`210`		`- break`
`211`	`206`	`case exitNotInRepo:`
`212`	`207`	`return fmt.Errorf("change directory to a repository to open in browser\n%s", help)`
`213`	`208`	`case exitTooManyFlags:`