Fix link in version output

mislav · mislav · commit 18b19e074da2 · 2020-12-17T12:37:22.000+01:00
It now correctly links to the tagged release instead of to the latest
release.
diff --git a/pkg/cmd/version/version.go b/pkg/cmd/version/version.go
@@ -26,11 +26,12 @@ func NewCmdVersion(f *cmdutil.Factory, version, buildDate string) *cobra.Command
 func Format(version, buildDate string) string {
 	version = strings.TrimPrefix(version, "v")
 
+	var dateStr string
 	if buildDate != "" {
-		version = fmt.Sprintf("%s (%s)", version, buildDate)
+		dateStr = fmt.Sprintf(" (%s)", buildDate)
 	}
 
-	return fmt.Sprintf("gh version %s\n%s\n", version, changelogURL(version))
+	return fmt.Sprintf("gh version %s%s\n%s\n", version, dateStr, changelogURL(version))
 }
 
 func changelogURL(version string) string {
diff --git a/pkg/cmd/version/version_test.go b/pkg/cmd/version/version_test.go
@@ -4,6 +4,13 @@ import (
 	"testing"
 )
 
+func TestFormat(t *testing.T) {
+	expects := "gh version 1.4.0 (2020-12-15)\nhttps://github.com/cli/cli/releases/tag/v1.4.0\n"
+	if got := Format("1.4.0", "2020-12-15"); got != expects {
+		t.Errorf("Format() = %q, wants %q", got, expects)
+	}
+}
+
 func TestChangelogURL(t *testing.T) {
 	tag := "0.3.2"
 	url := "https://github.com/cli/cli/releases/tag/v0.3.2"

Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,12 @@ func NewCmdVersion(f cmdutil.Factory, version, buildDate string) cobra.Command`
`26`	`26`	`func Format(version, buildDate string) string {`
`27`	`27`	`version = strings.TrimPrefix(version, "v")`
`28`	`28`
	`29`	`+ var dateStr string`
`29`	`30`	`if buildDate != "" {`
`30`		`- version = fmt.Sprintf("%s (%s)", version, buildDate)`
	`31`	`+ dateStr = fmt.Sprintf(" (%s)", buildDate)`
`31`	`32`	`}`
`32`	`33`
`33`		`- return fmt.Sprintf("gh version %s\n%s\n", version, changelogURL(version))`
	`34`	`+ return fmt.Sprintf("gh version %s%s\n%s\n", version, dateStr, changelogURL(version))`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`func changelogURL(version string) string {`