X Tutup
Skip to content

Commit 176dd29

Browse files
committed
Clarify our Go version requirements
* We are trying to keep the binary building on Go 1.13 to support building the project on Ubuntu 20.04 LTS * Go 1.14+ is required to run the test suite * We build our releases on Go 1.15 This adds a CI check that verifies that the project compiles on 1.13
1 parent 987e95f commit 176dd29

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

.github/CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ Please avoid:
2323
## Building the project
2424

2525
Prerequisites:
26-
- Go 1.14
26+
- Go 1.13+ for building the binary
27+
- Go 1.14+ for running the test suite
2728

2829
Build with: `make` or `go build -o bin/gh ./cmd/gh`
2930

.github/workflows/go.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,18 @@ jobs:
2525

2626
- name: Build
2727
run: go build -v ./cmd/gh
28+
29+
build-minimum:
30+
runs-on: ubuntu-latest
31+
32+
steps:
33+
- name: Set up Go 1.13
34+
uses: actions/setup-go@v2
35+
with:
36+
go-version: 1.13
37+
38+
- name: Check out code
39+
uses: actions/checkout@v2
40+
41+
- name: Build
42+
run: go build -v ./cmd/gh

docs/source.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
# Installation from source
22

3-
0. Verify that you have Go 1.15+ installed
3+
0. Verify that you have Go 1.13+ installed
44

55
```sh
66
$ go version
7-
go version go1.14
87
```
98

109
If `go` is not installed, follow instructions on [the Go website](https://golang.org/doc/install).

0 commit comments

Comments
 (0)
X Tutup