issue/pr comment: allow using editor in non-interactive mode

mislav · mislav · commit 0f1aaae57ce7 · 2022-02-18T18:38:55.000+01:00
The user should be able to `gh config set prompt disabled` and still be
allowed to use `gh issue comment --editor`.
diff --git a/pkg/cmd/pr/shared/commentable.go b/pkg/cmd/pr/shared/commentable.go
@@ -68,10 +68,6 @@ func CommentablePreRun(cmd *cobra.Command, opts *CommentableOptions) error {
 			return cmdutil.FlagErrorf("flags required when not running interactively")
 		}
 		opts.Interactive = true
-	} else if inputFlags == 1 {
-		if !opts.IO.CanPrompt() && opts.InputType == InputTypeEditor {
-			return cmdutil.FlagErrorf("`--body`, `--body-file` or `--web` required when not running interactively")
-		}
 	} else if inputFlags > 1 {
 		return cmdutil.FlagErrorf("specify only one of `--body`, `--body-file`, `--editor`, or `--web`")
 	}

Original file line number	Diff line number	Diff line change
`@@ -68,10 +68,6 @@ func CommentablePreRun(cmd cobra.Command, opts CommentableOptions) error {`
`68`	`68`	`return cmdutil.FlagErrorf("flags required when not running interactively")`
`69`	`69`	`}`
`70`	`70`	`opts.Interactive = true`
`71`		`- } else if inputFlags == 1 {`
`72`		`- if !opts.IO.CanPrompt() && opts.InputType == InputTypeEditor {`
`73`		- return cmdutil.FlagErrorf("`--body`, `--body-file` or `--web` required when not running interactively")
`74`		`- }`
`75`	`71`	`} else if inputFlags > 1 {`
`76`	`72`	return cmdutil.FlagErrorf("specify only one of `--body`, `--body-file`, `--editor`, or `--web`")
`77`	`73`	`}`