Escape workflow information when generating URLs

samcoe · samcoe · commit 03278453db20 · 2021-11-18T12:17:59.000-08:00
diff --git a/pkg/cmd/workflow/view/view.go b/pkg/cmd/workflow/view/view.go
@@ -3,6 +3,7 @@ package view
 import (
 	"fmt"
 	"net/http"
+	"net/url"
 	"strings"
 
 	"github.com/MakeNowJust/heredoc"
@@ -101,7 +102,7 @@ func runView(opts *ViewOptions) error {
 	}
 
 	if opts.Web {
-		var url string
+		var address string
 		if opts.YAML {
 			ref := opts.Ref
 			if ref == "" {
@@ -112,14 +113,14 @@ func runView(opts *ViewOptions) error {
 					return err
 				}
 			}
-			url = ghrepo.GenerateRepoURL(repo, "blob/%s/%s", ref, workflow.Path)
+			address = ghrepo.GenerateRepoURL(repo, "blob/%s/%s", url.QueryEscape(ref), url.QueryEscape(workflow.Path))
 		} else {
-			url = ghrepo.GenerateRepoURL(repo, "actions/workflows/%s", workflow.Base())
+			address = ghrepo.GenerateRepoURL(repo, "actions/workflows/%s", url.QueryEscape(workflow.Base()))
 		}
 		if opts.IO.IsStdoutTTY() {
-			fmt.Fprintf(opts.IO.Out, "Opening %s in your browser.\n", utils.DisplayURL(url))
+			fmt.Fprintf(opts.IO.Out, "Opening %s in your browser.\n", utils.DisplayURL(address))
 		}
-		return opts.Browser.Browse(url)
+		return opts.Browser.Browse(address)
 	}
 
 	if opts.YAML {

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ package view`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
`5`	`5`	`"net/http"`
	`6`	`+ "net/url"`
`6`	`7`	`"strings"`
`7`	`8`
`8`	`9`	`"github.com/MakeNowJust/heredoc"`
`@@ -101,7 +102,7 @@ func runView(opts *ViewOptions) error {`
`101`	`102`	`}`
`102`	`103`
`103`	`104`	`if opts.Web {`
`104`		`- var url string`
	`105`	`+ var address string`
`105`	`106`	`if opts.YAML {`
`106`	`107`	`ref := opts.Ref`
`107`	`108`	`if ref == "" {`
`@@ -112,14 +113,14 @@ func runView(opts *ViewOptions) error {`
`112`	`113`	`return err`
`113`	`114`	`}`
`114`	`115`	`}`
`115`		`- url = ghrepo.GenerateRepoURL(repo, "blob/%s/%s", ref, workflow.Path)`
	`116`	`+ address = ghrepo.GenerateRepoURL(repo, "blob/%s/%s", url.QueryEscape(ref), url.QueryEscape(workflow.Path))`
`116`	`117`	`} else {`
`117`		`- url = ghrepo.GenerateRepoURL(repo, "actions/workflows/%s", workflow.Base())`
	`118`	`+ address = ghrepo.GenerateRepoURL(repo, "actions/workflows/%s", url.QueryEscape(workflow.Base()))`
`118`	`119`	`}`
`119`	`120`	`if opts.IO.IsStdoutTTY() {`
`120`		`- fmt.Fprintf(opts.IO.Out, "Opening %s in your browser.\n", utils.DisplayURL(url))`
	`121`	`+ fmt.Fprintf(opts.IO.Out, "Opening %s in your browser.\n", utils.DisplayURL(address))`
`121`	`122`	`}`
`122`		`- return opts.Browser.Browse(url)`
	`123`	`+ return opts.Browser.Browse(address)`
`123`	`124`	`}`
`124`	`125`
`125`	`126`	`if opts.YAML {`