Set STRICT_ALL_TABLES when setting up DB (letsencrypt#1890)

jsha · jsha · commit 19da2be7ef1f · 2016-06-06T13:48:16.000-07:00
Fixes letsencrypt#1202.
diff --git a/sa/database.go b/sa/database.go
@@ -66,6 +66,10 @@ func NewDbMapFromConfig(config *mysql.Config, maxOpenConns int) (*gorp.DbMap, er
 	dbmap := &gorp.DbMap{Db: db, Dialect: dialect, TypeConverter: BoulderTypeConverter{}}
 
 	initTables(dbmap)
+	_, err = dbmap.Exec("SET sql_mode = 'STRICT_ALL_TABLES';")
+	if err != nil {
+		return nil, err
+	}
 
 	return dbmap, err
 }
diff --git a/sa/database_test.go b/sa/database_test.go
@@ -3,9 +3,11 @@ package sa
 import (
 	"database/sql"
 	"errors"
+	"strings"
 	"testing"
 
 	"github.com/letsencrypt/boulder/test"
+	"github.com/letsencrypt/boulder/test/vars"
 )
 
 func TestInvalidDSN(t *testing.T) {
@@ -58,3 +60,16 @@ func TestNewDbMap(t *testing.T) {
 	}
 
 }
+
+func TestStrictness(t *testing.T) {
+	dbMap, err := NewDbMap(vars.DBConnSA, 1)
+	_, err = dbMap.Exec(`insert into authz set
+		id="hi", identifier="foo", status="pending", combinations="combos",
+		registrationID=999999999999999999999999999;`)
+	if err == nil {
+		t.Fatal("Expected error when providing out of range value, got none.")
+	}
+	if !strings.Contains(err.Error(), "Out of range value for column") {
+		t.Fatalf("Got wrong type of error: %s", err)
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,10 @@ func NewDbMapFromConfig(config mysql.Config, maxOpenConns int) (gorp.DbMap, er`
`66`	`66`	`dbmap := &gorp.DbMap{Db: db, Dialect: dialect, TypeConverter: BoulderTypeConverter{}}`
`67`	`67`
`68`	`68`	`initTables(dbmap)`
	`69`	`+ _, err = dbmap.Exec("SET sql_mode = 'STRICT_ALL_TABLES';")`
	`70`	`+ if err != nil {`
	`71`	`+ return nil, err`
	`72`	`+ }`
`69`	`73`
`70`	`74`	`return dbmap, err`
`71`	`75`	`}`