X Tutup
Skip to content

Upgrade juice to 8.x#283

Merged
azu merged 1 commit intohonkit:masterfrom
deviantintegral:upgrade-juice
Jul 22, 2022
Merged

Upgrade juice to 8.x#283
azu merged 1 commit intohonkit:masterfrom
deviantintegral:upgrade-juice

Conversation

@deviantintegral
Copy link
Contributor

Tests pass for me locally.

@azu
Copy link
Member

azu commented Jul 21, 2022

https://www.npmjs.com/package/juice
It looks like juice is used in PDF generate process.

return Promise.nfcall(juice.juiceResources, tplOut.getContent(), {

Probably, There are no testing for PDF.

@azu
Copy link
Member

azu commented Jul 21, 2022

yarn honkit pdf in root dir generate PDF file for HonKit document.
If the pdf is not broken, this upgrade has valid.

Current PDF
book.pdf

@azu
Copy link
Member

azu commented Jul 21, 2022

This PR's PDF
book.pdf

@azu
Copy link
Member

azu commented Jul 22, 2022

It looks same result.

Thanks!

@azu azu merged commit 749bff2 into honkit:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup