X Tutup
Skip to content

fix(theme-default): fix Uncaught TypeError when click a page#196

Merged
azu merged 1 commit intomasterfrom
fix/191
Mar 27, 2021
Merged

fix(theme-default): fix Uncaught TypeError when click a page#196
azu merged 1 commit intomasterfrom
fix/191

Conversation

@azu
Copy link
Member

@azu azu commented Mar 27, 2021 •
edited
Loading

Currently, click body and throw an Error.

Uncaught TypeError: ((ke.event.special[i.origType] || {}).handle || i.handler).apply is not a function
    at HTMLDivElement.dispatch (theme.js:2)
    at HTMLDivElement.v.handle (theme.js:2)

This PR fixes it.

use native .focus({ preventScroll :true }) instead of jQuery.
It seems that jQuery does not support preventScroll.

fix #191
refs #135

@azu
Copy link
Member Author

azu commented Mar 27, 2021

Mar-27-2021.13-34-21.mp4

@azu azu merged commit 349aae6 into master Mar 27, 2021
@azu azu deleted the fix/191 branch March 27, 2021 04:39
@azu azu mentioned this pull request Mar 27, 2021
Merged
dogatana added a commit to dogatana/honkit-plugin-theme-default-fa5 that referenced this pull request Mar 29, 2021
@dogatana
fix: fix Uncaught TypeError when click a page
da36368 
- apply honkit/honkit#196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError when click a page

1 participant

@azu
X Tutup