Add publisher, producer, series, and author sort config options#108
Merged
azu merged 8 commits intohonkit:masterfrom Aug 6, 2020
anthonynelzinsantos:convert-options
Merged
Add publisher, producer, series, and author sort config options#108azu merged 8 commits intohonkit:masterfrom anthonynelzinsantos:convert-options
azu merged 8 commits intohonkit:masterfrom
anthonynelzinsantos:convert-options
Conversation
Necessary to work on macOS. Signed-off-by: Anthony Nelzin-Santos <anthony@nelzin.fr>
The book producer and publisher aren't harcoded anymore. Addresses #107. Signed-off-by: Anthony Nelzin-Santos <anthony@nelzin.fr>
Member
|
It seems that snapshot testing is failed. Probably, revert packages/honkit/src/tests/fixtures/honkit/docs/config.md changes and pass tests |
azu
reviewed
Aug 4, 2020
| | `title` | Title of your book, default value is extracted from the README. | | ||
| | `description` | Description of your book, default value is extracted from the README. | | ||
| | `author` | Name of the author. | | ||
| | `producer` | Name of the producer. | |
Member
There was a problem hiding this comment.
Ah, This is fixture files.
You do not need to update this.
You can pass the tests via revert this change instead of update snapshots.
#108 (comment)
Contributor
Author
There was a problem hiding this comment.
OK, I'll do that!
No need to update the fixtures! Duh. Signed-off-by: Anthony Nelzin-Santos <anthony@nelzin.fr>
No if statement needed, although the code would probably be more robust with one, as ebook-convert ignores empty params. Addresses #107. Signed-off-by: Anthony Nelzin-Santos <anthony@nelzin.fr>
Addresses #107. Signed-off-by: Anthony Nelzin-Santos <anthony@nelzin.fr>
Addresses #107. Signed-off-by: Anthony Nelzin-Santos <anthony@nelzin.fr>
Add hour to ensure ebook-convert will output the correct date. If no/erroneous date is provided, the compile time will be used. Addresses #107. Signed-off-by: Anthony Nelzin-Santos <anthony@nelzin.fr>
anthonynelzinsantos
changed the title
Contributor
Author
|
That should be better, now. |
azu
approved these changes
Aug 6, 2020
| | `publisher` | Name of the publisher. | | ||
| | `series` | The series this book belongs to. | | ||
| | `seriesIndex` | Index of the book in this series. | | ||
| | `pubdate` | Publication date of the book, formatted as YYYY-MM-DDTHH:MM:SS. | |
Member
|
We have release Release v3.6.0 · honkit/honkit 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #107, this PR adds the publisher and producer config options, to allow for a more flexible ePub output.