Allow overriding base_url on Client object initialization#364
Merged
jpoehnelt merged 1 commit intogooglemaps:masterfrom May 14, 2020
Merged
Allow overriding base_url on Client object initialization#364jpoehnelt merged 1 commit intogooglemaps:masterfrom
jpoehnelt merged 1 commit intogooglemaps:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
googlebot
added
the
cla: no
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
thatguysimon
force-pushed
the
overridable-base-url
branch
from
47a730a to
fe558e3
Compare
googlemaps-bot
pushed a commit
that referenced
this pull request
May 14, 2020
# [4.4.0](v4.3.1...v4.4.0) (2020-05-14) ### Features * Allow overriding base_url on Client object initialization ([#364](#364)) ([c875f35](c875f35))
Contributor
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Marir19950304
pushed a commit
to Marir19950304/Google_map
that referenced
this pull request
Jan 25, 2022
# [4.4.0](googlemaps/google-maps-services-python@v4.3.1...v4.4.0) (2020-05-14) ### Features * Allow overriding base_url on Client object initialization ([#364](googlemaps/google-maps-services-python#364)) ([c875f35](googlemaps/google-maps-services-python@c875f35))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently impossible to override _DEFAULT_BASE_URL because it's part of
_request's signature.This PR adds a
base_urlkeyword argument to theClientobject constructor and saves it in an instance variable._requestthen uses the instance variable when making the request (unless it's been provided with its own override)Overriding the base URL is necessary when setting up a mock server for testing purposes for example.
This issue was raised before in #204 but ended up not being addressed.