X Tutup
Skip to content

Always return a string in APIError.__str__#328

Merged
jpoehnelt merged 1 commit intogooglemaps:masterfrom
davidrobles:api-error-return-str
Nov 15, 2019
Merged

Always return a string in APIError.__str__#328
jpoehnelt merged 1 commit intogooglemaps:masterfrom
davidrobles:api-error-return-str

Conversation

@davidrobles
Copy link
Copy Markdown
Contributor

@davidrobles davidrobles commented Nov 15, 2019

If this is not wrapped in str it returns an int when the status_code is passed as the status.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          12       12           
  Lines         626      626           
=======================================
  Hits          562      562           
  Misses         64       64
Impacted Files Coverage Δ
googlemaps/exceptions.py 70.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cff8e5...06263ea. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 2947d61 into googlemaps:master Nov 15, 2019
@jpoehnelt jpoehnelt mentioned this pull request Nov 15, 2019
@jpoehnelt
Copy link
Copy Markdown
Contributor

Thanks for your contribution, published to https://pypi.org/project/googlemaps/3.1.4/.

pip install googlemaps==3.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup