X Tutup
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googlemaps/google-maps-services-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.2.1
Choose a base ref
...
head repository: googlemaps/google-maps-services-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.2.2
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Apr 23, 2020

  1. chore: Fix test.yml spacing.

    arriolac committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    68d35e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. fix: use timezone-aware timestamp() instead of timetuple() (#350)

    fixes issue where convert.time ignores timezone in the datetime object.
    
    current implementation:
    
    times = [
         datetime(2020, 3, 14, 8, 0, tzinfo=timezone.utc),
         datetime(2020, 3, 14, 9, 0, tzinfo=timezone(timedelta(hours=1))),
         datetime(2020, 3, 14, 8, 0, tzinfo=timezone(timedelta(hours=1)))
    ]
    for time in times:
    	print(convert.time(time))
    
    output:
    
    1584153000
    1584156600
    1584153000
    
    technically, as @atollena describes, the first two times should be
    considered to be the same, whereas the third datetime instance is
    expected be an hour behind the first two instances. but by using
    timetuple(), the specified timezone is ignored. so, using the
    timestamp() method instead of timetuple() ensures that the specified
    timezone is respected:
    
    new implementation (assuming the same list of times from before):
    
    for time in times:
    	print(convert.time(time))
    
    output:
    
    1584172800
    1584172800
    1584169200
    
    here, the specified timezone data is respected, and as expected the
    third datetime instance is 3600 seconds behind the first two instances.
    
    since python2 support has now been dropped, this can safely be included
    in the package.
    
    Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
    Thunderbottom authored Apr 24, 2020
    Configuration menu
    Copy the full SHA
    fc69668 View commit details
    Browse the repository at this point in the history
  2. chore(release): 4.2.2 [skip ci]

    ## [4.2.2](v4.2.1...v4.2.2) (2020-04-24)
    
    ### Bug Fixes
    
    * use timezone-aware timestamp() instead of timetuple() ([#350](#350)) ([fc69668](fc69668))
    semantic-release-bot committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    0c4aa3c View commit details
    Browse the repository at this point in the history
Loading
X Tutup