#798: Add support for auto-acknowledging pulled messages.#1637
#798: Add support for auto-acknowledging pulled messages.#1637tseaver wants to merge 2 commits intogoogleapis:masterfrom tseaver:798-jgeewax_strategy
Conversation
Follows @jgeewax's suggested implementation in: #798 (comment)
tseaver
added
do not merge
googlebot
added
the
cla: yes
|
Ugh, when did @coveralls turn back into a noisy commenter? |
I just disabled @coveralls commenting on the project page. |
|
How did you disable it? (Primarily I want to make sure the webhook is still active.) |
|
Looks fine (at least no issues with the code, though I realize this is a "design"-off challenge) |
|
There are separate flags for "Leave Comments" and "Use Status API":
|
|
FWIW, codecov can be bit better than coveralls at times. On Fri, Mar 18, 2016 at 11:06 AM Tres Seaver notifications@github.com
|
|
We don't have any allegiance, just in the "ain't broke" state |
docs/pubsub-usage.rst
Outdated
| ... batch.publish('this is the first message_payload') | ||
| ... batch.publish('this is the second message_payload', | ||
| ... attr1='value1', attr2='value2') | ||
| >>> from gcloud.pubsub.subscription import AutoAck |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
In favor of #1636 |
The Python SDK will use a hybrid approach for mTLS enablement: If the GOOGLE_API_USE_CLIENT_CERTIFICATE environment variable is set (either true or false or any value), the SDK will respect that setting. This is necessary for test scenarios and users who need to explicitly control mTLS behavior. If the GOOGLE_API_USE_CLIENT_CERTIFICATE environment variable is not set, the SDK will automatically enable mTLS only if it detects Managed Workload Identity (MWID) or X.509 Workforce Identity Federation (WIF) certificate sources. In other cases where the variable is not set, mTLS will remain disabled. --------- Signed-off-by: Radhika Agrawal <agrawalradhika@google.com> Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>
🤖 I have created a release *beep* *boop* --- ## [3.7.0](googleapis/python-storage@v3.6.0...v3.7.0) (2025-12-09) ### Features * Auto enable mTLS when supported certificates are detected ([#1637](googleapis/python-storage#1637)) ([4e91c54](googleapis/python-storage@4e91c54)) * Send entire object checksum in the final api call of resumable upload ([#1654](googleapis/python-storage#1654)) ([ddce7e5](googleapis/python-storage@ddce7e5)) * Support urllib3 >= 2.6.0 ([#1658](googleapis/python-storage#1658)) ([57405e9](googleapis/python-storage@57405e9)) ### Bug Fixes * **bucket:** Move blob fails when the new blob name contains characters that need to be url encoded ([#1605](googleapis/python-storage#1605)) ([ec470a2](googleapis/python-storage@ec470a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>
6 participants
Follows @jgeewax's suggested implementation.
Closes #798.
Hold off merging until comparing with the alternate implementation suggested by @tmatsuo (#1636).