Add support for batches to DNS#940
Merged
mziccard merged 6 commits intogoogleapis:masterfrom Apr 20, 2016
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes our
dns-alpha-batchbranch, rebases it on top of master ad applies some necessary rebase-related adjustments.Major adjustments are:
DnsExceptionidempotentfield in RpcBatch.Callback, see here for an exampleidempotentbeing correctly set by batchesresultparameter inDnsBatch.createXXXCallback()to avoid rawtypes warning. See here for an exampleThe discussion on batches can be found at #787