X Tutup
Skip to content

Bigtable: non-functional improvements relating to error handling#3809

Merged
igorbernstein2 merged 11 commits intogoogleapis:masterfrom
igorbernstein2:bigtable-errors
Oct 23, 2018
Merged

Bigtable: non-functional improvements relating to error handling#3809
igorbernstein2 merged 11 commits intogoogleapis:masterfrom
igorbernstein2:bigtable-errors

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

  • Add error handling examples to the javadocs
  • Use gax for error handling now that the code has been upstreamed
  • Fix outdated bigtable-admin readme

* Add error handling examples to the javadocs
* Use gax for error handling now that the code has been upstreamed
* Fix outdated bigtable-admin readme
@igorbernstein2 igorbernstein2 requested a review from a team October 11, 2018 15:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2018
@igorbernstein2 igorbernstein2 changed the title Bigtable: non-functional improvements Bigtable: non-functional improvements relating to error handling Oct 11, 2018
@sduskis sduskis added the api: bigtable Issues related to the Bigtable API. label Oct 12, 2018
Copy link
Copy Markdown

@kevinsi4508 kevinsi4508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things

* ApiFuture<Void> result = bigtableClient.bulkMutateRowsAsync(batch);
* ApiFuture<Void> resultFuture = bigtableClient.bulkMutateRowsAsync(batch);
*
* ApiFutures.addCallback(future, new ApiFutureCallback<Void>() {

This comment was marked as spam.

This comment was marked as spam.

@igorbernstein2
Copy link
Copy Markdown
Contributor Author

Thanks for the quick review. All feedback should be addressed

Copy link
Copy Markdown

@kevinsi4508 kevinsi4508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2
Copy link
Copy Markdown
Contributor Author

@pongad This should be ready for merging

@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@igorbernstein2 igorbernstein2 merged commit 827230e into googleapis:master Oct 23, 2018
@igorbernstein2 igorbernstein2 deleted the bigtable-errors branch October 23, 2018 18:10
@sduskis sduskis mentioned this pull request Oct 23, 2018
@JesseLovelace JesseLovelace mentioned this pull request Oct 25, 2018
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…onfig to v1.16.0 (#3809)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-shared-config](https://redirect.github.com/googleapis/java-shared-config)
| `1.15.4` -> `1.16.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:google-cloud-shared-config/1.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:google-cloud-shared-config/1.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:google-cloud-shared-config/1.15.4/1.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:google-cloud-shared-config/1.15.4/1.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleapis/java-shared-config
(com.google.cloud:google-cloud-shared-config)</summary>

###
[`v1.16.0`](https://redirect.github.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#1160-2025-05-27)

[Compare
Source](https://redirect.github.com/googleapis/java-shared-config/compare/v1.15.4...v1.16.0)

##### Features

- Update GraalVM image B to GraalVM for JDK 24
([#&#8203;1024](https://redirect.github.com/googleapis/java-shared-config/issues/1024))
([9ef9d8b](https://redirect.github.com/googleapis/java-shared-config/commit/9ef9d8bc0abedc59d9337cb5f3426bcadfaeb4a3))

##### Dependencies

- Update dependency org.graalvm.buildtools:native-maven-plugin to
v0.10.6
([#&#8203;1004](https://redirect.github.com/googleapis/java-shared-config/issues/1004))
([f123860](https://redirect.github.com/googleapis/java-shared-config/commit/f123860c0919c542d34f4b96e54e3378b0b5b433))
- Update dependency org.graalvm.sdk:graal-sdk to v24.2.1
([#&#8203;1021](https://redirect.github.com/googleapis/java-shared-config/issues/1021))
([28a41c7](https://redirect.github.com/googleapis/java-shared-config/commit/28a41c787a00514d7515e7f7f9242769cbb450b5))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNi4wIiwidXBkYXRlZEluVmVyIjoiNDAuMzMuNiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup