Bigtable: non-functional improvements relating to error handling#3809
Merged
igorbernstein2 merged 11 commits intogoogleapis:masterfrom Oct 23, 2018
Merged
Bigtable: non-functional improvements relating to error handling#3809igorbernstein2 merged 11 commits intogoogleapis:masterfrom
igorbernstein2 merged 11 commits intogoogleapis:masterfrom
Conversation
Contributor
igorbernstein2
commented
Oct 11, 2018
- Add error handling examples to the javadocs
- Use gax for error handling now that the code has been upstreamed
- Fix outdated bigtable-admin readme
* Add error handling examples to the javadocs * Use gax for error handling now that the code has been upstreamed * Fix outdated bigtable-admin readme
kevinsi4508
reviewed
Oct 12, 2018
...able-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java
Show resolved
Hide resolved
...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
Show resolved
Hide resolved
| * ApiFuture<Void> result = bigtableClient.bulkMutateRowsAsync(batch); | ||
| * ApiFuture<Void> resultFuture = bigtableClient.bulkMutateRowsAsync(batch); | ||
| * | ||
| * ApiFutures.addCallback(future, new ApiFutureCallback<Void>() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
Show resolved
Hide resolved
...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the quick review. All feedback should be addressed |
Contributor
Author
|
@pongad This should be ready for merging |
sduskis
approved these changes
Oct 22, 2018
Merged
Merged
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
…onfig to v1.16.0 (#3809) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://redirect.github.com/googleapis/java-shared-config) | `1.15.4` -> `1.16.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleapis/java-shared-config (com.google.cloud:google-cloud-shared-config)</summary> ### [`v1.16.0`](https://redirect.github.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#1160-2025-05-27) [Compare Source](https://redirect.github.com/googleapis/java-shared-config/compare/v1.15.4...v1.16.0) ##### Features - Update GraalVM image B to GraalVM for JDK 24 ([#​1024](https://redirect.github.com/googleapis/java-shared-config/issues/1024)) ([9ef9d8b](https://redirect.github.com/googleapis/java-shared-config/commit/9ef9d8bc0abedc59d9337cb5f3426bcadfaeb4a3)) ##### Dependencies - Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.6 ([#​1004](https://redirect.github.com/googleapis/java-shared-config/issues/1004)) ([f123860](https://redirect.github.com/googleapis/java-shared-config/commit/f123860c0919c542d34f4b96e54e3378b0b5b433)) - Update dependency org.graalvm.sdk:graal-sdk to v24.2.1 ([#​1021](https://redirect.github.com/googleapis/java-shared-config/issues/1021)) ([28a41c7](https://redirect.github.com/googleapis/java-shared-config/commit/28a41c787a00514d7515e7f7f9242769cbb450b5)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNi4wIiwidXBkYXRlZEluVmVyIjoiNDAuMzMuNiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.