Exists method added by elisheva-qlogic · Pull Request #3769 · googleapis/google-cloud-java

elisheva-qlogic · 2018-10-04T17:57:34Z

exists method added in BigtableTableAdminClient to check if table exists #3636

...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

+   * }</pre>
+   */
+  public boolean exists(String tableId) {
+    List<TableName> tableNames = this.listTables();


...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

+      String table = tableName.toString();
+      String separator = "/";
+      int index = table.lastIndexOf(separator);
+      String name = table.substring(index + separator.length());


...ble-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java

+    boolean found = adminClient.exists(TABLE_NAME.getTable());
+
+    // Verify
+    Assert.assertTrue(found);


...ble-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java

...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

+    return ApiFutures.transform(listTablesAsync(), new ApiFunction<List<TableName>, Boolean>() {
+      @Override public Boolean apply(List<TableName> tableNames) {
+        for(TableName tableName : tableNames) {
+          if(tableName.getTable().equalsIgnoreCase(tableId)) {


...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

+    return listTablesAsync(com.google.bigtable.admin.v2.Table.View.NAME_ONLY);
+  }
+
+  public ApiFuture<List<TableName>> listTablesAsync(com.google.bigtable.admin.v2.Table.View view) {


...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

+  }
+
+  public ApiFuture<Boolean> existsAsync(final String tableId) {
+    return ApiFutures.transform(listTablesAsync(), new ApiFunction<List<TableName>, Boolean>() {


igorbernstein2

This looks pretty good, just needs some stylistic fixes

...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

...ble-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java

+                    .setName(TABLE_NAME.toString())
+                    .build();
+
+    Mockito.when(mockGetTableCallable.futureCall(Matchers.any(GetTableRequest.class))).thenReturn(ApiFutures.immediateFuture(expectedResponse));


...ble-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java

-import com.google.bigtable.admin.v2.GetTableRequest;
-import com.google.bigtable.admin.v2.InstanceName;
-import com.google.bigtable.admin.v2.ListTablesRequest;
+import com.google.bigtable.admin.v2.*;


...ble-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java

    // Setup
    GetTableRequest expectedRequest = GetTableRequest.newBuilder()
        .setName(TABLE_NAME.toString())
+        .setView(com.google.bigtable.admin.v2.Table.View.SCHEMA_VIEW)


...ble-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java

igorbernstein2

One last nit about sample code, but this LGTM

...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

+   *  found,
+   *  new ApiFutureCallback<Boolean>() {
+   *    public void onSuccess(Boolean found) {
+   *      System.out.println("Table exists");


...ble-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java

+        new NotFoundException("fake error", null, GrpcStatusCode.of(Status.Code.NOT_FOUND), false);
+
+    Mockito.when(mockGetTableCallable.futureCall(Matchers.any(GetTableRequest.class)))
+        .thenReturn(ApiFutures.immediateFailedFuture(exception));


sduskis · 2018-10-23T20:32:41Z

@elisheva-qlogic, there's a compilation failure:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project google-cloud-bigtable-admin: Compilation failure
[ERROR] /tmpfs/src/github/google-cloud-java/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java:[339,12] cannot find symbol
[ERROR] symbol: method awaitFuture(com.google.api.core.ApiFuture<java.lang.Boolean>)
[ERROR] location: class com.google.cloud.bigtable.admin.v2.BigtableTableAdminClient

It looks like a merge conflict with PR #3809

igorbernstein2 · 2018-10-23T21:27:29Z

I think I fixed the issue

….1 to 3.3.3 in /java-shared-dependencies/unmanaged-dependency-check (#3769) Bumps [org.apache.maven.shared:maven-shared-utils](https://github.com/apache/maven-shared-utils) from 3.2.1 to 3.3.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/apache/maven-shared-utils/commit/cc010396156386d95e2acbc28f7aba32590243a2"><code>cc01039</code></a> [maven-release-plugin] prepare release maven-shared-utils-3.3.3</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/abdc90ccc36326dc6ee61ac497d2005e9e6637ef"><code>abdc90c</code></a> [maven-release-plugin] prepare for next development iteration</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/5460b13f6f4230d5ddce3fe8ffb241ab42254346"><code>5460b13</code></a> [maven-release-plugin] prepare release maven-shared-utils-3.3.2</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/60d005240b324e08661471fe6b0db981e2a0bd58"><code>60d0052</code></a> [maven-release-plugin] prepare for next development iteration</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/b3f78c16715d237b2d915d5cb963eef18b0d9fd2"><code>b3f78c1</code></a> [maven-release-plugin] prepare release maven-shared-utils-3.3.1</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/d1acca0bfaa7eda578f522f8d7851af074dbaa1c"><code>d1acca0</code></a> Bump version to 3.3.1 in preparation for release.</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/5ff997cac035ac7d2ab84bbd2c695c6e60798400"><code>5ff997c</code></a> [MSHARED-848] deprecate XmlStreamReader (<a href="https://redirect.github.com/apache/maven-shared-utils/issues/59">#59</a>)</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/914d9755b157f337dfb76e90f6b0331f834096d6"><code>914d975</code></a> remove call to deprecated method (<a href="https://redirect.github.com/apache/maven-shared-utils/issues/58">#58</a>)</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/dda9e1480f4f51120f619dfd302ed0d10807dfa5"><code>dda9e14</code></a> [MSHARED-904] update test dependencies for Maven 3.1 (<a href="https://redirect.github.com/apache/maven-shared-utils/issues/57">#57</a>)</li> <li><a href="https://github.com/apache/maven-shared-utils/commit/6798f3033c3c5144e52c5aa8e1be584ea97527d2"><code>6798f30</code></a> [MSHARED-297] - Minor code cleanup</li> <li>Additional commits viewable in <a href="https://github.com/apache/maven-shared-utils/compare/maven-shared-utils-3.2.1...maven-shared-utils-3.3.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.shared:maven-shared-utils&package-manager=maven&previous-version=3.2.1&new-version=3.3.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/googleapis/sdk-platform-java/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Min Zhu <zhumin@google.com>

Exist method added

60e60c2

elisheva-qlogic requested a review from pongad as a code owner October 4, 2018 17:57

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2018

chingor13 requested a review from igorbernstein2 October 4, 2018 18:14

chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2018

igorbernstein2 suggested changes Oct 4, 2018

View reviewed changes

exists_method_corrections

257e586

elisheva-qlogic requested a review from a team October 11, 2018 16:26

igorbernstein2 suggested changes Oct 11, 2018

View reviewed changes

sduskis added the api: bigtable Issues related to the Bigtable API. label Oct 12, 2018

exists_method_updated

71e561a

igorbernstein2 suggested changes Oct 17, 2018

View reviewed changes

style_fixes

d5552a3

sduskis suggested changes Oct 18, 2018

View reviewed changes

elisheva-qlogic and others added 2 commits October 18, 2018 12:59

fixed_imports

e399d95

Merge branch 'master' into exist_method

35da0af

igorbernstein2 reviewed Oct 19, 2018

View reviewed changes

...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java Outdated

* found,

* new ApiFutureCallback<Boolean>() {

* public void onSuccess(Boolean found) {

* System.out.println("Table exists");

This comment was marked as spam.

Sign in to view

igorbernstein2 mentioned this pull request Oct 19, 2018

Bigtable data client comment update #3833

Merged

elisheva-qlogic force-pushed the exist_method branch from 60e99f2 to 35da0af Compare October 22, 2018 14:19

sample code

8516f90

igorbernstein2 approved these changes Oct 22, 2018

View reviewed changes

Merge branch 'master' into exist_method

5b58404

sduskis approved these changes Oct 22, 2018

View reviewed changes

Merge branch 'master' into exist_method

17171b2

igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018

igorbernstein2 suggested changes Oct 23, 2018

View reviewed changes

elisheva-qlogic and others added 2 commits October 23, 2018 13:57

fix

a407ecb

Merge branch 'master' into exist_method

bcfc65e

igorbernstein2 approved these changes Oct 23, 2018

View reviewed changes

igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018

Fix merge conflict

e668e08

igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018

igorbernstein2 merged commit 0e1bc68 into googleapis:master Oct 23, 2018

JesseLovelace mentioned this pull request Oct 25, 2018

Release v0.68.0 #3857

Merged

elisheva-qlogic deleted the exist_method branch November 8, 2018 14:30

suztomo pushed a commit that referenced this pull request Mar 9, 2026

chore(deps): update google cloud java monorepo updates (#3769)

f0dc90c

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

chore(deps): update google cloud java monorepo updates (#3769)

ce4d28f

Conversation

elisheva-qlogic commented Oct 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

igorbernstein2 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

sduskis commented Oct 23, 2018

Uh oh!

igorbernstein2 commented Oct 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

elisheva-qlogic commented Oct 4, 2018 •

edited

Loading