Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test reproduces an issue with ackDeadline. It publishes 2 messages, then it pools them and nacks one of them. The other one is not being nacked or acked. Then it tries to pull both messages again, in a loop.
The ackDeadline is set to 10 seconds, so I would expect to get both messages after that time. But the message that wasn't nacked or acked never makes it back.
What is interesting, if I enable debugging and put a break point inside the loop, I am able to get both messages.
I verified that ackDeadline works as expected in gcloud cli tool.