X Tutup
Skip to content

Exposing TransportChannelProvider & CredentialsProvider#3320

Merged
schmidt-sebastian merged 4 commits intomasterfrom
mrschmidt-options
Jun 8, 2018
Merged

Exposing TransportChannelProvider & CredentialsProvider#3320
schmidt-sebastian merged 4 commits intomasterfrom
mrschmidt-options

Conversation

@schmidt-sebastian
Copy link
Copy Markdown
Contributor

@schmidt-sebastian schmidt-sebastian commented May 29, 2018

Disclaimer: I am still wrapping my head around the initialization code for Veneer clients, so please shout if this doesn't make sense.

This PR is mainly intended to allow users to specify the size of the GRPC channel pool, but it exposes a way to set all options consumed in the venner-generated FirestoreSettings. AFAIK, there was no way to overwrite the TransportChannelProvider or the CredentialsProvider.

Code snippet that sets the max pool size:

Builder options =  FirestoreOptions.newBuilder().build().toBuilder();
options.setChannelProvider(
   FirestoreOptions.getDefaultTransportChannelProviderBuilder().setPoolSize(2).build());
firestore = options.build().getService();

Without this setting, Firestore is limited to 100 concurrent listeners.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup