Exposing TransportChannelProvider & CredentialsProvider#3320
Merged
schmidt-sebastian merged 4 commits intomasterfrom Jun 8, 2018
Merged
Exposing TransportChannelProvider & CredentialsProvider#3320schmidt-sebastian merged 4 commits intomasterfrom
schmidt-sebastian merged 4 commits intomasterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I am still wrapping my head around the initialization code for Veneer clients, so please shout if this doesn't make sense.
This PR is mainly intended to allow users to specify the size of the GRPC channel pool, but it exposes a way to set all options consumed in the venner-generated FirestoreSettings. AFAIK, there was no way to overwrite the TransportChannelProvider or the CredentialsProvider.
Code snippet that sets the max pool size:
Without this setting, Firestore is limited to 100 concurrent listeners.