Return Dates as com.google.cloud.Timestamps#3317
Merged
schmidt-sebastian merged 4 commits intomasterfrom Jun 6, 2018
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the changes from cr/191495680 and enables Firestore to return com.google.cloud.Timestamps with nanosecond precision.
The PR also removes Instant from the Firestore codebase, and instead returns and uses com.google.cloud.Timestamp everwhere.
About half the lines in this PR are from updating
CustomClassMapperto the version in Google3. Review at your own digression (it's mostly copy&paste).