X Tutup
Skip to content

Catching Throwable in transactions#3224

Merged
pongad merged 1 commit intomasterfrom
mrschmidt-errortransaction
May 2, 2018
Merged

Catching Throwable in transactions#3224
pongad merged 1 commit intomasterfrom
mrschmidt-errortransaction

Conversation

@schmidt-sebastian
Copy link
Copy Markdown
Contributor

Fixes #320

@schmidt-sebastian schmidt-sebastian requested a review from pongad as a code owner May 2, 2018 16:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2018
@pongad pongad merged commit f12dc34 into master May 2, 2018
@pongad pongad deleted the mrschmidt-errortransaction branch May 2, 2018 19:03
suztomo pushed a commit that referenced this pull request Mar 9, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.api.grpc:grpc-google-common-protos](https://redirect.github.com/googleapis/sdk-platform-java)
| `2.44.0` -> `2.45.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.api.grpc:grpc-google-common-protos/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.api.grpc:grpc-google-common-protos/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.api.grpc:grpc-google-common-protos/2.44.0/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.api.grpc:grpc-google-common-protos/2.44.0/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.api.grpc:grpc-google-iam-v1](https://redirect.github.com/googleapis/sdk-platform-java)
| `1.39.0` -> `1.40.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.api.grpc:grpc-google-iam-v1/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.api.grpc:grpc-google-iam-v1/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.api.grpc:grpc-google-iam-v1/1.39.0/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.api.grpc:grpc-google-iam-v1/1.39.0/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.api.grpc:proto-google-common-protos](https://redirect.github.com/googleapis/sdk-platform-java)
| `2.44.0` -> `2.45.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.api.grpc:proto-google-common-protos/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.api.grpc:proto-google-common-protos/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.api.grpc:proto-google-common-protos/2.44.0/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.api.grpc:proto-google-common-protos/2.44.0/2.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.api.grpc:proto-google-iam-v1](https://redirect.github.com/googleapis/sdk-platform-java)
| `1.39.0` -> `1.40.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.api.grpc:proto-google-iam-v1/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.api.grpc:proto-google-iam-v1/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.api.grpc:proto-google-iam-v1/1.39.0/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.api.grpc:proto-google-iam-v1/1.39.0/1.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.api:api-common](https://redirect.github.com/googleapis/sdk-platform-java)
| `2.36.0` -> `2.37.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.api:api-common/2.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.api:api-common/2.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.api:api-common/2.36.0/2.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.api:api-common/2.36.0/2.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleapis/sdk-platform-java
(com.google.api.grpc:grpc-google-common-protos)</summary>

###
[`v2.45.0`](https://redirect.github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2450-2024-09-09)

[Compare
Source](https://redirect.github.com/googleapis/sdk-platform-java/compare/v2.44.0...v2.45.0)

##### Features

- add Batcher#close(timeout) and Batcher#cancelOutstanding
([#&#8203;3141](https://redirect.github.com/googleapis/sdk-platform-java/issues/3141))
([68fd533](https://redirect.github.com/googleapis/sdk-platform-java/commit/68fd533ebb9a15d87c257e9af80be81ee8d0a1cd))
- add full RetrySettings sample code to Settings classes
([#&#8203;3056](https://redirect.github.com/googleapis/sdk-platform-java/issues/3056))
([6fd1b0e](https://redirect.github.com/googleapis/sdk-platform-java/commit/6fd1b0ef7aea65c8e491fb4206641224c2be81cf))
- add toString to futures returned by operations
([#&#8203;3140](https://redirect.github.com/googleapis/sdk-platform-java/issues/3140))
([fbdbe04](https://redirect.github.com/googleapis/sdk-platform-java/commit/fbdbe04e059761df116f760697fd6b178f205020))
- bake gapic-generator-java into the hermetic build docker image
([#&#8203;3067](https://redirect.github.com/googleapis/sdk-platform-java/issues/3067))
([96d45e1](https://redirect.github.com/googleapis/sdk-platform-java/commit/96d45e18becfb31aef2183e762a0c8649ad58c8b))

##### Bug Fixes

- **gax:** prevent truncation/overflow when converting time values
([#&#8203;3095](https://redirect.github.com/googleapis/sdk-platform-java/issues/3095))
([95366a6](https://redirect.github.com/googleapis/sdk-platform-java/commit/95366a64a52a2779b0302f0fc61a1d44be1f1a0b))

##### Dependencies

- add opentelemetry exporter-metrics and shared-resoucemapping to shared
dependencies
([#&#8203;3078](https://redirect.github.com/googleapis/sdk-platform-java/issues/3078))
([dd7d6e4](https://redirect.github.com/googleapis/sdk-platform-java/commit/dd7d6e427725e189fd888cf046fb4655274c7997))
- update dependency certifi to v2024.8.30
([#&#8203;3150](https://redirect.github.com/googleapis/sdk-platform-java/issues/3150))
([2a2c1f6](https://redirect.github.com/googleapis/sdk-platform-java/commit/2a2c1f6b0e46fc2245d21f5dfc51d73f1f02eb93))
- update dependency com.google.api-client:google-api-client-bom to
v2.7.0
([#&#8203;3151](https://redirect.github.com/googleapis/sdk-platform-java/issues/3151))
([9defdc9](https://redirect.github.com/googleapis/sdk-platform-java/commit/9defdc9c82c9582b60258bc1cf7a65aad02a9059))
- update dependency com.google.errorprone:error_prone_annotations to
v2.31.0
([#&#8203;3153](https://redirect.github.com/googleapis/sdk-platform-java/issues/3153))
([494abe9](https://redirect.github.com/googleapis/sdk-platform-java/commit/494abe9f3236e72fdfd83f39e05421048adfae1b))
- update dependency com.google.errorprone:error_prone_annotations to
v2.31.0
([#&#8203;3154](https://redirect.github.com/googleapis/sdk-platform-java/issues/3154))
([7bf94b1](https://redirect.github.com/googleapis/sdk-platform-java/commit/7bf94b1cc4a5efb4b926320e8712ecf3ad471665))
- update dependency com.google.guava:guava to v33.3.0-jre
([#&#8203;3119](https://redirect.github.com/googleapis/sdk-platform-java/issues/3119))
([2f33f20](https://redirect.github.com/googleapis/sdk-platform-java/commit/2f33f20fcb35e0aa17fbfebe06ad3a1a0d4483eb))
- update dependency dev.cel:cel to v0.7.1
([#&#8203;3155](https://redirect.github.com/googleapis/sdk-platform-java/issues/3155))
([8db2f84](https://redirect.github.com/googleapis/sdk-platform-java/commit/8db2f84eb3bf1b3e7a4f9f918bcc77e9c4684f4a))
- update dependency filelock to v3.16.0
([#&#8203;3175](https://redirect.github.com/googleapis/sdk-platform-java/issues/3175))
([2091eba](https://redirect.github.com/googleapis/sdk-platform-java/commit/2091ebac3eaec68acb4c240876c1c9b28d105fe1))
- update dependency idna to v3.8
([#&#8203;3156](https://redirect.github.com/googleapis/sdk-platform-java/issues/3156))
([0668758](https://redirect.github.com/googleapis/sdk-platform-java/commit/066875861491bc897c07d0ee916842790ace28c3))
- update dependency io.netty:netty-tcnative-boringssl-static to
v2.0.66.final
([#&#8203;3148](https://redirect.github.com/googleapis/sdk-platform-java/issues/3148))
([7729251](https://redirect.github.com/googleapis/sdk-platform-java/commit/7729251692503f6f7a0a4466cd1c3bf7df384049))
- update dependency net.bytebuddy:byte-buddy to v1.15.1
([#&#8203;3115](https://redirect.github.com/googleapis/sdk-platform-java/issues/3115))
([e173c58](https://redirect.github.com/googleapis/sdk-platform-java/commit/e173c5837c62a10998582b6ab9ecd6f7fb694608))
- update dependency org.apache.commons:commons-lang3 to v3.17.0
([#&#8203;3157](https://redirect.github.com/googleapis/sdk-platform-java/issues/3157))
([a37dc70](https://redirect.github.com/googleapis/sdk-platform-java/commit/a37dc7058564e12f19a7cf814bc9a59c364f92f9))
- update dependency org.checkerframework:checker-qual to v3.47.0
([#&#8203;3166](https://redirect.github.com/googleapis/sdk-platform-java/issues/3166))
([912e1e0](https://redirect.github.com/googleapis/sdk-platform-java/commit/912e1e0fff822d676e559dfc15dd92874cce29af))
- update dependency org.yaml:snakeyaml to v2.3
([#&#8203;3158](https://redirect.github.com/googleapis/sdk-platform-java/issues/3158))
([0ed2059](https://redirect.github.com/googleapis/sdk-platform-java/commit/0ed205908a0b8e008888beb338307e95db60a3f1))
- update dependency platformdirs to v4.3.2
([#&#8203;3176](https://redirect.github.com/googleapis/sdk-platform-java/issues/3176))
([610fadc](https://redirect.github.com/googleapis/sdk-platform-java/commit/610fadc461545b9929b8c40c460bd5f4fc6a93c7))
- update dependency virtualenv to v20.26.4
([#&#8203;3177](https://redirect.github.com/googleapis/sdk-platform-java/issues/3177))
([bcef38a](https://redirect.github.com/googleapis/sdk-platform-java/commit/bcef38ada9a5b447f30156777f101258b0c31096))
- update google api dependencies
([#&#8203;3118](https://redirect.github.com/googleapis/sdk-platform-java/issues/3118))
([b32b80b](https://redirect.github.com/googleapis/sdk-platform-java/commit/b32b80bcd7525a5c0df5eb3d25a522bda0f2e792))
- update google auth library dependencies to v1.25.0
([#&#8203;3168](https://redirect.github.com/googleapis/sdk-platform-java/issues/3168))
([f48afb7](https://redirect.github.com/googleapis/sdk-platform-java/commit/f48afb742dd9a08a8b76a173b1932d6d4a5c0659))
- update google http client dependencies to v1.45.0
([#&#8203;3159](https://redirect.github.com/googleapis/sdk-platform-java/issues/3159))
([e1cd2fc](https://redirect.github.com/googleapis/sdk-platform-java/commit/e1cd2fcff1d5396af4733d04f05f02d1f7ac2fbb))
- update googleapis/java-cloud-bom digest to
[`6626f91`](https://redirect.github.com/googleapis/sdk-platform-java/commit/6626f91)
([#&#8203;3147](https://redirect.github.com/googleapis/sdk-platform-java/issues/3147))
([db9e878](https://redirect.github.com/googleapis/sdk-platform-java/commit/db9e87827bdf162fd890568adb4466b3ff234d86))
- update junit5 monorepo to v5.11.0
([#&#8203;3111](https://redirect.github.com/googleapis/sdk-platform-java/issues/3111))
([b11b5dc](https://redirect.github.com/googleapis/sdk-platform-java/commit/b11b5dcaed6b144bd884afb43b1e2fb55107f607))
- update netty dependencies to v4.1.113.final
([#&#8203;3165](https://redirect.github.com/googleapis/sdk-platform-java/issues/3165))
([1be261a](https://redirect.github.com/googleapis/sdk-platform-java/commit/1be261a1e8835514c17c44bce110e94545b7af97))
- update opentelemetry-java monorepo to v1.42.0
([#&#8203;3172](https://redirect.github.com/googleapis/sdk-platform-java/issues/3172))
([ef61b8c](https://redirect.github.com/googleapis/sdk-platform-java/commit/ef61b8c26b95259f70a3a65bb33839cbcaa8ffbe))

##### Documentation

- Update DEVELOPMENT.md
([#&#8203;3126](https://redirect.github.com/googleapis/sdk-platform-java/issues/3126))
([b7670c4](https://redirect.github.com/googleapis/sdk-platform-java/commit/b7670c4e53138db4879ff7f99f71ac97e2c92e0e))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://redirect.github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>2.46.1</summary>

##
[2.46.1](googleapis/sdk-platform-java@v2.46.0...v2.46.1)
(2024-09-25)


### Dependencies

* update dependency black to v24.8.0
([#3234](googleapis/sdk-platform-java#3234))
([e773ec3](googleapis/sdk-platform-java@e773ec3))
* update dependency lxml to v5.3.0
([#3237](googleapis/sdk-platform-java#3237))
([ac6e622](googleapis/sdk-platform-java@ac6e622))
* update dependency net.bytebuddy:byte-buddy to v1.15.2
([#3235](googleapis/sdk-platform-java#3235))
([1e72ff0](googleapis/sdk-platform-java@1e72ff0))
* update dependency pyyaml to v6.0.2
([#3231](googleapis/sdk-platform-java#3231))
([200f332](googleapis/sdk-platform-java@200f332))
* update dependency watchdog to v4.0.2
([#3232](googleapis/sdk-platform-java#3232))
([60b7721](googleapis/sdk-platform-java@60b7721))
* update google api dependencies
([#3224](googleapis/sdk-platform-java#3224))
([0de08b2](googleapis/sdk-platform-java@0de08b2))
* update google.cloud.opentelemetry.version to v0.32.0
([#3225](googleapis/sdk-platform-java#3225))
([861f188](googleapis/sdk-platform-java@861f188))
* update grpc dependencies to v1.68.0
([#3220](googleapis/sdk-platform-java#3220))
([618288c](googleapis/sdk-platform-java@618288c))
* update junit5 monorepo to v5.11.1
([#3236](googleapis/sdk-platform-java#3236))
([1550ceb](googleapis/sdk-platform-java@1550ceb))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
The test used the error code RESOURCE_EXHAUSTED to indicate that
the server could not create any more sessions. This error code is
now retryable, causing the test to become flaky. Change the error
code to one that is not retryable.

Fixes #3224
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
## Description
feat: *breaking behavior* rewrite Storage.blobAppendableUpload to be non-blocking and have improved throughput (#3231)

Rewrite internals of BlobAppendableUpload to provide non-blocking write calls, and it take advantage of grpc async message handling.

When `AppendableUploadWriteableByteChannel#write(ByteBuffer)` is called, an attempt will be made to enqueue the bytes in the outbound queue to GCS.
If there is only enough room to partially consume the bytes provided in the `ByteBuffer` the write call will return early specifying the number of bytes actually consumed.

As acknowledgements come in from gcs, enqueued messages will be evicted freeing space in the outbound queue. Thereby allowing more bytes to be consumed and enqueued.

Given appendable objects are still in private preview I can't quote any metrics here, however preliminary benchmarking of several million objects across a range of sizes show across the board throughput improvments.

Because the channel's write call is now non-blocking, if you want to block your application until the full buffer is consumed some new helper methods have been added in StorageChannelUtils to provide blocking behavior.

A new method `MinFlushSizeFlushPolicy#withMaxPendingBytes(long)` has been added to allow limiting the number of pending outbound bytes. The default values is 16MiB, but can be configured lower if necessary.

## Release Notes

BEGIN_COMMIT_OVERRIDE

BEGIN_NESTED_COMMIT
feat: *breaking behavior* rewrite Storage.blobAppendableUpload to be non-blocking and have improved throughput (#3231)
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add StorageChannelUtils to provide helper methods to perform blocking read/write to/from non-blocking channels (#3231)
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add MinFlushSizeFlushPolicy#withMaxPendingBytes(long) (#3231)
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: update BlobAppendableUploadConfig and FlushPolicy.MinFlushSizeFlushPolicy to default to 4MiB minFlushSize and 16MiB maxPendingBytes (#3249)
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: make FlushPolicy${Min,Max}FlushSizeFlushPolicy constructors private (#3217)
END_NESTED_COMMIT

END_COMMIMT_OVERRIDE

## Sub PRs
This PR is made of up the following PRs, in sequence
1. #3217
2. #3218 
3. #3219
4. #3220
5. #3221
6. #3222
7. #3223
8. #3224 
9. #3225 
10. #3226 
11. #3227 
12. #3228 
13. #3229 
14. #3230 
15. #3235 
16. #3236 
17. #3241
18. #3242
19. #3246
20. #3248
21. #3249
22. #3252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup